From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [patch] net/mlx4: && vs & typo Date: Wed, 1 Mar 2017 07:52:01 +0100 (CET) Message-ID: References: <20170228120215.GA27947@mwanda> <1488296129.3056.1.camel@sandisk.com> <1488320630.25838.39.camel@perches.com> <1D08B61A9CF0974AA09887BE32D889DA0C193A@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Joe Perches , "eugenia@mellanox.com" , "dan.carpenter@oracle.com" , "yishaih@mellanox.com" , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" To: Bart Van Assche Return-path: Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:13854 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbdCAGz2 (ORCPT ); Wed, 1 Mar 2017 01:55:28 -0500 In-Reply-To: <1D08B61A9CF0974AA09887BE32D889DA0C193A@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 28 Feb 2017, Bart Van Assche wrote: > On 02/28/2017 02:23 PM, Joe Perches wrote: > > On Tue, 2017-02-28 at 15:35 +0000, Bart Van Assche wrote: > >> On Tue, 2017-02-28 at 15:02 +0300, Dan Carpenter wrote: > >>> Bitwise & was obviously intended here. > > [] > >>> diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h > > [] > >>> @@ -109,7 +109,7 @@ static inline void (u8 *addr, u64 mac) > >>> int i; > >>> > >>> for (i = ETH_ALEN; i > 0; i--) { > >>> - addr[i - 1] = mac && 0xFF; > >>> + addr[i - 1] = mac & 0xFF; > >>> mac >>= 8; > >>> } > >>> } > >> > >> Is this the only place where such a loop occurs? > > > > Seems to be. > > > >> Should a put_unaligned_be48() > >> function be introduced? > > > > Why? This is used exactly once. > > Really? Here is an example of another open-coded version of > put_unaligned_be48() from arch/mips/cavium-octeon/octeon-platform.c: > > new_mac[0] = (mac >> 40) & 0xff; > new_mac[1] = (mac >> 32) & 0xff; > new_mac[2] = (mac >> 24) & 0xff; > new_mac[3] = (mac >> 16) & 0xff; > new_mac[4] = (mac >> 8) & 0xff; > new_mac[5] = mac & 0xff; drivers/media/radio/radio-shark2.c: for (i = 0; i < 6; i++) shark->transfer_buffer[i + 1] = (reg >> (40 - i * 8)) & 0xff; drivers/rtc/rtc-ab3100.c buf[0] = (hw_counter) & 0xFF; buf[1] = (hw_counter >> 8) & 0xFF; buf[2] = (hw_counter >> 16) & 0xFF; buf[3] = (hw_counter >> 24) & 0xFF; buf[4] = (hw_counter >> 32) & 0xFF; buf[5] = (hw_counter >> 40) & 0xFF; drivers/net/ethernet/sun/ldmvsw.c for (i = 0; i < ETH_ALEN; i++) port->raddr[i] = (*rmac >> (5 - i) * 8) & 0xff; drivers/net/ethernet/sun/sunvnet.c for (i = 0; i < ETH_ALEN; i++) dev->dev_addr[i] = (*local_mac >> (5 - i) * 8) & 0xff; for (i = 0; i < ETH_ALEN; i++) port->raddr[i] = (*rmac >> (5 - i) * 8) & 0xff; julia > > Bart. > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >