From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH] dsa: mv88e6xxx: fix returnvar.cocci warnings Date: Sat, 27 May 2017 06:38:14 +0200 (CEST) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: netdev@vger.kernel.org, Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org To: Andrew Lunn Return-path: Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:24873 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbdE0EiR (ORCPT ); Sat, 27 May 2017 00:38:17 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Andrew Lunn Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- It's a minor issue, but since there is no error, the code is a bit misleading. tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 47936d35edbac5e58064bd15e51136050b2f2717 commit: 04aca9938255fc7097b3fb5700f408524656f2e2 [330/362] dsa: mv88e6xxx: Enable/Disable SERDES on port enable/disable chip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -1982,13 +1982,12 @@ static int mv88e6xxx_port_enable(struct struct phy_device *phydev) { struct mv88e6xxx_chip *chip = ds->priv; - int err = 0; mutex_lock(&chip->reg_lock); mv88e6xxx_serdes_power(chip, port, true); mutex_unlock(&chip->reg_lock); - return err; + return 0; } static void mv88e6xxx_port_disable(struct dsa_switch *ds, int port,