From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F42FC31E4C for ; Fri, 14 Jun 2019 12:21:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E21BF20850 for ; Fri, 14 Jun 2019 12:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727696AbfFNMV1 (ORCPT ); Fri, 14 Jun 2019 08:21:27 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:19416 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727619AbfFNMV1 (ORCPT ); Fri, 14 Jun 2019 08:21:27 -0400 X-IronPort-AV: E=Sophos;i="5.63,373,1557180000"; d="scan'208";a="309260432" Received: from unknown (HELO hadrien.local) ([163.173.90.224]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 14:21:24 +0200 Date: Fri, 14 Jun 2019 14:21:23 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Christophe JAILLET cc: aviad.krawczyk@huawei.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] hinic: Use devm_kasprintf instead of hard coding it In-Reply-To: Message-ID: References: <20190613195412.1702-1-christophe.jaillet@wanadoo.fr> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-573815791-1560514884=:9068" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --8323329-573815791-1560514884=:9068 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Fri, 14 Jun 2019, Christophe JAILLET wrote: > Hi, > > I got a: > > : host huawei.com[103.218.216.136] said: 550 > 5.1.1 Error: invalid recipients is found from 80.12.242.127 > > However, MAINTAINERS has: > HUAWEI ETHERNET DRIVER > M: Aviad Krawczyk > L: netdev@vger.kernel.org > S: Supported > F: Documentation/networking/hinic.txt > F: drivers/net/ethernet/huawei/hinic/ > > I don't know how this should be fixed (neither if it should be...), so if s.o. > knows, please do. Maybe this person would know, since he is also from Huawei and has signed off on a patch by Aviad Krawczyk: cde66f24c3bf42123647c5233447c5790d92557f Signed-off-by: Zhao Chen julia > > Best regards, > Christophe Jaillet > > Le 13/06/2019 à 21:54, Christophe JAILLET a écrit : > > 'devm_kasprintf' is less verbose than: > > snprintf(NULL, 0, ...); > > devm_kzalloc(...); > > sprintf > > so use it instead. > > > > Signed-off-by: Christophe JAILLET > > --- > > drivers/net/ethernet/huawei/hinic/hinic_rx.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c > > b/drivers/net/ethernet/huawei/hinic/hinic_rx.c > > index 9b4082557ad5..95b09fd110d3 100644 > > --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c > > +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c > > @@ -493,7 +493,7 @@ int hinic_init_rxq(struct hinic_rxq *rxq, struct > > hinic_rq *rq, > > struct net_device *netdev) > > { > > struct hinic_qp *qp = container_of(rq, struct hinic_qp, rq); > > - int err, pkts, irqname_len; > > + int err, pkts; > > rxq->netdev = netdev; > > rxq->rq = rq; > > @@ -502,13 +502,11 @@ int hinic_init_rxq(struct hinic_rxq *rxq, struct > > hinic_rq *rq, > > rxq_stats_init(rxq); > > - irqname_len = snprintf(NULL, 0, "hinic_rxq%d", qp->q_id) + 1; > > - rxq->irq_name = devm_kzalloc(&netdev->dev, irqname_len, GFP_KERNEL); > > + rxq->irq_name = devm_kasprintf(&netdev->dev, GFP_KERNEL, > > + "hinic_rxq%d", qp->q_id); > > if (!rxq->irq_name) > > return -ENOMEM; > > - sprintf(rxq->irq_name, "hinic_rxq%d", qp->q_id); > > - > > pkts = rx_alloc_pkts(rxq); > > if (!pkts) { > > err = -ENOMEM; > > > --8323329-573815791-1560514884=:9068--