From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C45B5C43381 for ; Tue, 19 Feb 2019 09:04:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D9A92146F for ; Tue, 19 Feb 2019 09:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727777AbfBSJEx (ORCPT ); Tue, 19 Feb 2019 04:04:53 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:22539 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbfBSJEw (ORCPT ); Tue, 19 Feb 2019 04:04:52 -0500 X-IronPort-AV: E=Sophos;i="5.58,387,1544482800"; d="scan'208";a="369973608" Received: from abo-58-107-68.mrs.modulonet.fr (HELO hadrien) ([85.68.107.58]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2019 10:04:15 +0100 Date: Tue, 19 Feb 2019 10:04:15 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Mao Wenan cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org, Julia Lawall Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy() In-Reply-To: <20190219090635.134457-1-maowenan@huawei.com> Message-ID: References: <20190219090635.134457-1-maowenan@huawei.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 19 Feb 2019, Mao Wenan wrote: > This patch is to do code cleanup for ns83820_probe_phy(). > It deletes unused variable 'first' and commented out code. > > Signed-off-by: Mao Wenan Acked-by: Julia Lawall > --- > v2->v3: delte unused variable 'first'; change subject from > "net: ns83820: drop pointless static qualifier in ns83820_probe_phy()" to > "net: ns83820: code cleanup for ns83820_probe_phy()". > drivers/net/ethernet/natsemi/ns83820.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c > index 958fced4dacf..955d34a6f0d8 100644 > --- a/drivers/net/ethernet/natsemi/ns83820.c > +++ b/drivers/net/ethernet/natsemi/ns83820.c > @@ -1869,34 +1869,16 @@ static unsigned ns83820_mii_write_reg(struct ns83820 *dev, unsigned phy, unsigne > static void ns83820_probe_phy(struct net_device *ndev) > { > struct ns83820 *dev = PRIV(ndev); > - static int first; > int i; > #define MII_PHYIDR1 0x02 > #define MII_PHYIDR2 0x03 > > -#if 0 > - if (!first) { > - unsigned tmp; > - ns83820_mii_read_reg(dev, 1, 0x09); > - ns83820_mii_write_reg(dev, 1, 0x10, 0x0d3e); > - > - tmp = ns83820_mii_read_reg(dev, 1, 0x00); > - ns83820_mii_write_reg(dev, 1, 0x00, tmp | 0x8000); > - udelay(1300); > - ns83820_mii_read_reg(dev, 1, 0x09); > - } > -#endif > - first = 1; > - > for (i=1; i<2; i++) { > int j; > unsigned a, b; > a = ns83820_mii_read_reg(dev, i, MII_PHYIDR1); > b = ns83820_mii_read_reg(dev, i, MII_PHYIDR2); > > - //printk("%s: phy %d: 0x%04x 0x%04x\n", > - // ndev->name, i, a, b); > - > for (j=0; j<0x16; j+=4) { > dprintk("%s: [0x%02x] %04x %04x %04x %04x\n", > ndev->name, j, > -- > 2.20.1 > >