From: Julia Lawall <julia.lawall@lip6.fr>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: qlge: correct misspelled word
Date: Wed, 9 Oct 2019 22:51:22 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1910092249300.2570@hadrien> (raw)
In-Reply-To: <20191009194115.5513-1-jbi.octave@gmail.com>
On Wed, 9 Oct 2019, Jules Irenge wrote:
> Correct misspelled word " check
Why is there a " in the above line?
You don't need to put a newline after check.
> issued by checkpatch.pl tool:
> "CHECK: serveral may be misspelled - perhaps several?".
It's not reall necessary to give the checkpatch message in this case,
although it is good to acknowledge checkpatch. You could say something
like:
Fix a misspelling of "several" detected by checkpatch.
julia
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/qlge/qlge_dbg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 086f067fd899..097fab7b4287 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -354,7 +354,7 @@ static int ql_get_xgmac_regs(struct ql_adapter *qdev, u32 *buf,
>
> for (i = PAUSE_SRC_LO; i < XGMAC_REGISTER_END; i += 4, buf++) {
> /* We're reading 400 xgmac registers, but we filter out
> - * serveral locations that are non-responsive to reads.
> + * several locations that are non-responsive to reads.
> */
> if ((i == 0x00000114) ||
> (i == 0x00000118) ||
> --
> 2.21.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191009194115.5513-1-jbi.octave%40gmail.com.
>
prev parent reply other threads:[~2019-10-09 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 19:41 [PATCH] staging: qlge: correct misspelled word Jules Irenge
2019-10-09 20:51 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910092249300.2570@hadrien \
--to=julia.lawall@lip6.fr \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox