Re: [PATCH] MAINTAINERS: correct entries for ISDN/mISDN section

Joe Perches
2020-02-01T18:43:25Z

On Sat, 2020-02-01 at 13:43 +0100, Lukas Bulwahn wrote:
> Commit 6d97985072dc ("isdn: move capi drivers to staging") cleaned up the
> isdn drivers and split the MAINTAINERS section for ISDN, but missed to add
> the terminal slash for the two directories mISDN and hardware. Hence, all
> files in those directories were not part of the new ISDN/mISDN SUBSYSTEM,
> but were considered to be part of "THE REST".

Not really.

> Rectify the situation, and while at it, also complete the section with two
> further build files that belong to that subsystem.
>
> This was identified with a small script that finds all files belonging to
> "THE REST" according to the current MAINTAINERS file, and I investigated
> upon its output.

I believe the MAINTAINERS file will be better with the
proposed patch.

Perhaps this is a defect in the small script as
get_maintainer does already show the directory and
files as being maintained.

ie: get_maintainer.pl does this:

##if pattern is a directory and it lacks a trailing slash, add one
if ((-d $value)) {
$value =~ s@([^/])$@$1/@;
}

So:

$ ./scripts/get_maintainer.pl -f drivers/isdn/mISDN
Karsten Keil <isdn@linux-pingi.de> (maintainer:ISDN/mISDN SUBSYSTEM)
netdev@vger.kernel.org (open list:ISDN/mISDN SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

and

$ ./scripts/get_maintainer.pl -f drivers/isdn/mISDN/dsp.h
Karsten Keil <isdn@linux-pingi.de> (maintainer:ISDN/mISDN SUBSYSTEM)
netdev@vger.kernel.org (open list:ISDN/mISDN SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

> Fixes: 6d97985072dc ("isdn: move capi drivers to staging")

And this patch likely does not warrant a 'Fixes:' tag.

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Arnd, please ack or even pick it.
> It is no functional change, so I guess you could simply pick in your own
> tree for minor fixes.
>
> MAINTAINERS | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1f77fb8cdde3..b6a0c4fa8cfd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8908,8 +8908,10 @@ L: isdn4linux@listserv.isdn4linux.de (subscribers-only)
> L: netdev@vger.kernel.org
> W: http://www.isdn4linux.de
> S: Maintained
> -F: drivers/isdn/mISDN
> -F: drivers/isdn/hardware
> +F: drivers/isdn/mISDN/
> +F: drivers/isdn/hardware/
> +F: drivers/isdn/Kconfig
> +F: drivers/isdn/Makefile
>
> ISDN/CMTP OVER BLUETOOTH
> M: Karsten Keil <isdn@linux-pingi.de>