Re: [PATCH] MAINTAINERS: correct entries for ISDN/mISDN section

Lukas Bulwahn
2020-02-01T21:30:06Z

On Sat, 1 Feb 2020, Joe Perches wrote:

> On Sat, 2020-02-01 at 20:15 +0100, Lukas Bulwahn wrote:
> > On Sat, Feb 1, 2020 at 7:43 PM Joe Perches <joe@perches.com> wrote:
> > > Perhaps this is a defect in the small script as
> > > get_maintainer does already show the directory and
> > > files as being maintained.
> > >
> > > ie: get_maintainer.pl does this:
> > >
> > > ##if pattern is a directory and it lacks a trailing slash, add one
> > > if ((-d $value)) {
> > > $value =~ s@([^/])$@$1/@;
> > > }
> > >
> >
> > True. My script did not implement that logic; I will add that to my
> > script as well.
> > Fortunately, that is not the major case of issues I have found and
> > they might need some improvements.
>
> You might also try ./scripts/get_maintainer.pl --self-test

Thanks for letting me know about that functionality.

It looks like quite some work to get those warnings sorted out properly. I
will check to address the most important/disturbing ones that I see.

>
> And here's an attached script to update any missing
> MAINTAINER [FX]: directory slashes and what it produces
> against today's -next.

I probably make use of that script, at least for some intermediate
processing.

Lukas