From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBBFBC43331 for ; Fri, 3 Apr 2020 13:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A87EE206E9 for ; Fri, 3 Apr 2020 13:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390883AbgDCNqn (ORCPT ); Fri, 3 Apr 2020 09:46:43 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:45831 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728023AbgDCNqn (ORCPT ); Fri, 3 Apr 2020 09:46:43 -0400 X-IronPort-AV: E=Sophos;i="5.72,339,1580770800"; d="scan'208";a="344841719" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2020 15:46:41 +0200 Date: Fri, 3 Apr 2020 15:46:40 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: olteanv@gmail.com cc: netdev@vger.kernel.org, joe@perches.com Subject: question about drivers/net/dsa/sja1105/sja1105_main.c Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, The function sja1105_static_config_reload in sja1105_main.c contains the code: if (!an_enabled) { int speed = SPEED_UNKNOWN; if (bmcr & BMCR_SPEED1000) speed = SPEED_1000; else if (bmcr & BMCR_SPEED100) speed = SPEED_100; else if (bmcr & BMCR_SPEED10) speed = SPEED_10; sja1105_sgmii_pcs_force_speed(priv, speed); } The last test bmcr & BMCR_SPEED10 does not look correct, because according to include/uapi/linux/mii.h, BMCR_SPEED10 is 0. What should be done instead? thanks, julia