From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MALFORMED_FREEMAIL,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8862C43457 for ; Mon, 12 Oct 2020 13:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7314206D9 for ; Mon, 12 Oct 2020 13:51:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="phQ8c5GM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390145AbgJLNvo (ORCPT ); Mon, 12 Oct 2020 09:51:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389973AbgJLNtw (ORCPT ); Mon, 12 Oct 2020 09:49:52 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80E26C0613D7; Mon, 12 Oct 2020 06:49:51 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id t20so10697078edr.11; Mon, 12 Oct 2020 06:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=HsbAp6qd7g4JTk6QFw04+VFZUaG3bIXSc1NpoNbfqf8=; b=phQ8c5GMkXNgAEiW9pg3lAWEQS1b60Omw7uWqN0NQUjcppagPTYtroAw8rKpJsTb9G +QD9RAx2vJoncFxbg7zUExmhvBJh9nr0yR8gsAZ+SJseY4NuhdNgHnBcmFPOgFnizuzQ qRWHPuXVuZfx+32H/GUCF7uWBhp7NMaJQyeeZBxbPQx2vFXSU00hdF39rgfPJGfhKy55 EdmRUfZY16sG7yJvjcvET3KkhQ5rBeWMGrGfh6X0kZE747vjAP6eRX24+chUkhcZbMGw 4/5ETyAd+LZsEtsdqJGe764PuvmLDlQASUw7tIvKy3SsBWyY4wCYUlUdQXVNqKdGY0UK T2/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=HsbAp6qd7g4JTk6QFw04+VFZUaG3bIXSc1NpoNbfqf8=; b=IpE6cDGEHNJUHYu1djq5WNwPFiC+FohCMvI5yKzz2p0Qpopx2rdZdlaPFbB1N1/7XT Ft9LgUV9iXx+2atz5u0jgUlYT6fPIFdrMbQgFuinx5DlmVaHloyS9UKJ9DGIPQnzfZpG 48xjdVAli2dee7o8yTPvxBtedR0xTIxuVqpKXHOe1ziVpZBYuKv9Ll5iS63dk5qL577r PSNxok4bG+8iKrI7wF1BYJtzG2M5r4VIBzkz8rSmPN1w6V3leYen4/tQM4gsJ3WuKyQY qKpDXy4BwYeLhUERxwSGvXMrcfntAkayOlXEdrxrpRiHpDb4vjh2FWjXyrc+BsAAUe8c lJQw== X-Gm-Message-State: AOAM5320YJjgVf3b31hkLdkIreF9cvB5Y18DJu+4b5QpbTaus7vjI56T 9rfP6x9FV8Ikx3rZrg+qzvI= X-Google-Smtp-Source: ABdhPJxFkYpU7K3AS5LxjIDvju41ZYqpsBIoDPX+SHxU23/hUALjax3K659HVU/Z5ZE7dilKv7q/kw== X-Received: by 2002:aa7:cd4f:: with SMTP id v15mr13718665edw.243.1602510590180; Mon, 12 Oct 2020 06:49:50 -0700 (PDT) Received: from felia ([2001:16b8:2d57:fc00:8472:203c:3ecb:c442]) by smtp.gmail.com with ESMTPSA id u17sm8233872ejj.83.2020.10.12.06.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 06:49:49 -0700 (PDT) From: Lukas Bulwahn X-Google-Original-From: Lukas Bulwahn Date: Mon, 12 Oct 2020 15:49:48 +0200 (CEST) X-X-Sender: lukas@felia To: Sudip Mukherjee cc: Jesse Brandeburg , Tony Nguyen , "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [linux-safety] [PATCH] e1000: drop unneeded assignment in e1000_set_itr() In-Reply-To: <20201011212326.2758-1-sudipm.mukherjee@gmail.com> Message-ID: References: <20201011212326.2758-1-sudipm.mukherjee@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 11 Oct 2020, Sudip Mukherjee wrote: > The variable 'current_itr' is assigned to 0 before jumping to > 'set_itr_now' but it has not been used after the jump. So, remove the > unneeded assignement. > > Signed-off-by: Sudip Mukherjee > --- > drivers/net/ethernet/intel/e1000/e1000_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c > index 5e28cf4fa2cd..042de276e632 100644 > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c > @@ -2632,7 +2632,6 @@ static void e1000_set_itr(struct e1000_adapter *adapter) > > /* for non-gigabit speeds, just fix the interrupt rate at 4000 */ > if (unlikely(adapter->link_speed != SPEED_1000)) { > - current_itr = 0; > new_itr = 4000; > goto set_itr_now; > } Alternatively, you could just inline the max(...) into the switch and completely drop the current_itr definition. But your solution probably does the job: it is a "No functional change" commit. Reviewed-by: Lukas Bulwahn Lukas > -- > 2.11.0 > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#77): https://lists.elisa.tech/g/linux-safety/message/77 > Mute This Topic: https://lists.elisa.tech/mt/77448709/1714638 > Group Owner: linux-safety+owner@lists.elisa.tech > Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [lukas.bulwahn@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > > >