From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7434CC433E1 for ; Sun, 12 Jul 2020 07:05:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 580C32065F for ; Sun, 12 Jul 2020 07:05:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728273AbgGLHF0 (ORCPT ); Sun, 12 Jul 2020 03:05:26 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:56393 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727777AbgGLHFQ (ORCPT ); Sun, 12 Jul 2020 03:05:16 -0400 X-IronPort-AV: E=Sophos;i="5.75,342,1589234400"; d="scan'208";a="459480431" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2020 09:05:13 +0200 Date: Sun, 12 Jul 2020 09:05:13 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Christophe JAILLET cc: Joe Perches , mlindner@marvell.com, stephen@networkplumber.org, davem@davemloft.net, kuba@kernel.org, hch@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net: sky2: switch from 'pci_' to 'dma_' API In-Reply-To: Message-ID: References: <20200711204944.259152-1-christophe.jaillet@wanadoo.fr> <2181026e68d2948c396cc7a7b6bfb7146c1cd5f6.camel@perches.com> <8a3e5514-9cc9-18f3-9a98-81007419a20a@wanadoo.fr> <866325009f9ae73b3a563dd745f901260a372242.camel@perches.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-794464576-1594537513=:2424" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-794464576-1594537513=:2424 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Sun, 12 Jul 2020, Christophe JAILLET wrote: > Le 12/07/2020 à 08:32, Joe Perches a écrit : > > On Sun, 2020-07-12 at 08:29 +0200, Christophe JAILLET wrote: > > > Le 11/07/2020 à 23:20, Joe Perches a écrit : > > > > On Sat, 2020-07-11 at 22:49 +0200, Christophe JAILLET wrote: > > > > > The wrappers in include/linux/pci-dma-compat.h should go away. > > > > why? > > > > > > > > > > > From Christoph Hellwig > > > https://marc.info/?l=kernel-janitors&m=158745678307186&w=4 > > There's no why there. > > There's just an assertion a wrapper should "go away". > > > > "the wrappers in include/linux/pci-dma-compat.h should go away" > > > > wrappers aren't all bad. > > > > > Adding Christoph Hellwig to shed some light. Neither the wrapped name nor the unwrapped name is higher or lower level. Nothing much happens to the arguments. The wrappers and the wrapped functions are not used entirely consistently, eg some files, and perhaps even some functions, use a mixture of the two. There a set of confusingly named constants associated with the two sets of functions, and these constants are also not always used consistently. julia --8323329-794464576-1594537513=:2424--