From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2912AC433E5 for ; Tue, 14 Jul 2020 14:16:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F3EC22507 for ; Tue, 14 Jul 2020 14:16:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728486AbgGNOQS (ORCPT ); Tue, 14 Jul 2020 10:16:18 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:6915 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbgGNOQR (ORCPT ); Tue, 14 Jul 2020 10:16:17 -0400 X-IronPort-AV: E=Sophos;i="5.75,350,1589234400"; d="scan'208";a="459696777" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 16:16:15 +0200 Date: Tue, 14 Jul 2020 16:16:15 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Suraj Upadhyay cc: davem@davemloft.net, kuba@kernel.org, linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] decnet: dn_dev: Remove an unnecessary label. In-Reply-To: <20200714141309.GA3184@blackclown> Message-ID: References: <20200714141309.GA3184@blackclown> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 14 Jul 2020, Suraj Upadhyay wrote: > Remove the unnecessary label from dn_dev_ioctl() and make its error > handling simpler to read. > > Signed-off-by: Suraj Upadhyay > --- > net/decnet/dn_dev.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c > index 65abcf1b3210..64901bb9f314 100644 > --- a/net/decnet/dn_dev.c > +++ b/net/decnet/dn_dev.c > @@ -462,7 +462,9 @@ int dn_dev_ioctl(unsigned int cmd, void __user *arg) > switch (cmd) { > case SIOCGIFADDR: > *((__le16 *)sdn->sdn_nodeaddr) = ifa->ifa_local; > - goto rarok; > + if (copy_to_user(arg, ifr, DN_IFREQ_SIZE)) > + ret = -EFAULT; > + break; The indentation on break does not look correct. julia > > case SIOCSIFADDR: > if (!ifa) { > @@ -485,10 +487,6 @@ int dn_dev_ioctl(unsigned int cmd, void __user *arg) > rtnl_unlock(); > > return ret; > -rarok: > - if (copy_to_user(arg, ifr, DN_IFREQ_SIZE)) > - ret = -EFAULT; > - goto done; > } > > struct net_device *dn_dev_get_default(void) > -- > 2.17.1 > >