From: Pekka Riikonen <priikone@iki.fi>
To: Simon Horman <horms@verge.net.au>
Cc: dev@openvswitch.org, netdev@vger.kernel.org,
"Jesse Gross" <jesse@nicira.com>,
"Pravin B Shelar" <pshelar@nicira.com>,
jarno.rajahalme@nsn.com, "Eric Dumazet" <eric.dumazet@gmail.com>,
"Maciej Żenczykowski" <maze@google.com>
Subject: Re: [PATCH next-next v4 1/2] net: Use 16bits for inner_*_headers fields of struct skbuff
Date: Wed, 22 May 2013 09:25:16 +0200 (CEST) [thread overview]
Message-ID: <alpine.GSO.2.00.1305220923130.11532@git.silcnet.org> (raw)
In-Reply-To: <1369205836-9407-2-git-send-email-horms@verge.net.au>
On Wed, 22 May 2013, Simon Horman wrote:
> include/linux/skbuff.h | 63 +++++++-------------------------------------------
> 1 file changed, 8 insertions(+), 55 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 2e0ced1..3791615 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -509,9 +509,9 @@ struct sk_buff {
> __u32 reserved_tailroom;
> };
>
> - sk_buff_data_t inner_transport_header;
> - sk_buff_data_t inner_network_header;
> - sk_buff_data_t inner_mac_header;
> + __u16 inner_transport_header;
> + __u16 inner_network_header;
> + __u16 inner_mac_header;
> sk_buff_data_t transport_header;
> sk_buff_data_t network_header;
> sk_buff_data_t mac_header;
>
Why not take one more step and use 16-bit fields for the other header
fields too: transport_header, network_header and mac_header?
Pekka
next prev parent reply other threads:[~2013-05-22 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 6:57 [PATCH next-next v4 0/2] MPLS: Add limited GSO support Simon Horman
2013-05-22 6:57 ` [PATCH next-next v4 1/2] net: Use 16bits for inner_*_headers fields of struct skbuff Simon Horman
2013-05-22 7:25 ` Pekka Riikonen [this message]
2013-05-22 11:32 ` Eric Dumazet
2013-05-24 1:38 ` David Miller
2013-05-22 6:57 ` [PATCH next-next v4 2/2] MPLS: Add limited GSO support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.GSO.2.00.1305220923130.11532@git.silcnet.org \
--to=priikone@iki.fi \
--cc=dev@openvswitch.org \
--cc=eric.dumazet@gmail.com \
--cc=horms@verge.net.au \
--cc=jarno.rajahalme@nsn.com \
--cc=jesse@nicira.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox