From: Satyam Sharma <satyam@infradead.org>
To: Petko Manolov <petkan@nucleusys.com>
Cc: linux-usb-devel@lists.sourceforge.net,
Petko Manolov <petkan@users.sourceforge.net>,
Greg Kroah-Hartman <greg@kroah.com>,
Jesper Juhl <jesper.juhl@gmail.com>,
Oliver Neukum <oliver@neukum.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.
Date: Mon, 30 Jul 2007 14:24:30 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.0.999.0707301422160.13448@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <Pine.LNX.4.64.0707301053020.3113@bender.nucleusys.com>
On Mon, 30 Jul 2007, Petko Manolov wrote:
> On Sun, 29 Jul 2007, Oliver Neukum wrote:
>
> > [...]
> > pegasus == NULL there would be a kernel bug. Silently ignoring
> > it, like the code now wants to do is bad. As the oops has never been
> > reported, I figure turning it into an explicit debugging test is overkill,
> > so removal seems to be the best option.
>
> In the past urb->context was not guaranteed to be non-null for any
> asynchronous calls. If this is not the case anymore then it should be removed
> from at least two more locations in the driver.
>
> Attached you'll find the resulting patch.
Given Oliver's earlier comment, it looks okay to me. Thanks.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
prev parent reply other threads:[~2007-07-30 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-28 22:19 [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference Jesper Juhl
2007-07-28 23:37 ` Satyam Sharma
2007-07-28 23:55 ` Jesper Juhl
2007-07-29 8:49 ` [linux-usb-devel] " Oliver Neukum
2007-07-29 18:18 ` Satyam Sharma
2007-07-30 8:05 ` Petko Manolov
2007-07-30 8:54 ` Satyam Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0707301422160.13448@enigma.security.iitk.ac.in \
--to=satyam@infradead.org \
--cc=greg@kroah.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=petkan@nucleusys.com \
--cc=petkan@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).