From mboxrd@z Thu Jan 1 00:00:00 1970 From: Satyam Sharma Subject: Re: [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference. Date: Mon, 30 Jul 2007 14:24:30 +0530 (IST) Message-ID: References: <200707290019.02591.jesper.juhl@gmail.com> <9a8748490707281655u66e50bbfqba58687b579a85fe@mail.gmail.com> <200707291049.26619.oliver@neukum.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-usb-devel@lists.sourceforge.net, Petko Manolov , Greg Kroah-Hartman , Jesper Juhl , Oliver Neukum , Linux Kernel Mailing List , netdev@vger.kernel.org To: Petko Manolov Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-usb-devel-bounces@lists.sourceforge.net Errors-To: linux-usb-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Mon, 30 Jul 2007, Petko Manolov wrote: > On Sun, 29 Jul 2007, Oliver Neukum wrote: > > > [...] > > pegasus == NULL there would be a kernel bug. Silently ignoring > > it, like the code now wants to do is bad. As the oops has never been > > reported, I figure turning it into an explicit debugging test is overkill, > > so removal seems to be the best option. > > In the past urb->context was not guaranteed to be non-null for any > asynchronous calls. If this is not the case anymore then it should be removed > from at least two more locations in the driver. > > Attached you'll find the resulting patch. Given Oliver's earlier comment, it looks okay to me. Thanks. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel