From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [patch] e1000=y && e1000e=m regression fix Date: Sun, 13 Apr 2008 14:13:01 -0700 (PDT) Message-ID: References: <47FBDBE9.9040700@garzik.org> <20080409193850.GA11763@elte.hu> <47FD2325.2030705@intel.com> <47FE5C89.5060209@intel.com> <20080410192714.GA14055@elte.hu> <47FE8566.5040809@intel.com> <20080411112653.GC9205@elte.hu> <20080411113644.GA7767@infradead.org> <20080411121606.GA25661@elte.hu> <47FF9060.5040202@intel.com> <20080411164542.GA4066@infradead.org> <47FFF7B5.3000609@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "Rafael J. Wysocki" , "Kok, Auke" , Andrew Morton , Matthew Wilcox , e1000-list , NetDev , Daniel Barkalow , "Allan, Bruce W" , Linux Kernel Mailing List , "David S. Miller" , Christoph Hellwig , Jesse Brandeburg , "Ronciak, John" , Greg KH , Ingo Molnar , Arjan van de Ven , linux-pci maillist To: Jeff Garzik Return-path: In-Reply-To: <47FFF7B5.3000609@garzik.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: e1000-devel-bounces@lists.sourceforge.net Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Fri, 11 Apr 2008, Jeff Garzik wrote: > Linus Torvalds wrote: > > .. but that said, I think your patch is certainly better than what we have > > now (or what Ingo was complaining about for the next merge window). I > > certainly could live with it. I would just suggest against ever then > > removing that "generic E1000" choice. > > You mean never ever remove PCI-E support from e1000? No. I mean never ever remove the *configure* level thinking that "e1000 is e1000". There is no sense in *ever* showing it as two drivers to users, because users do not see them as separate chipsets. They look identical, down to the part names. If it's a single family, and users can't even easily tell whether they have version 1 or version 2 (PCI vs PCI-E), you shouldn't even ask them. You should literally ask them: "do you want e1000 support". That's it. Once you have asked them that, you can then decide "ok, if you *really* know what version of the chip you have, you can decide to only get limited driver support". But that's a secondary thing from a user perspective. See the patch I already sent out. Linus ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone