From: WANG Cong <xiyou.wangcong@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, davem@davemloft.net, akpm@osdl.org,
netdev@vger.kernel.org
Subject: Re: [Patch]net/xfrm/xfrm_policy.c: replace timer with delayed_work
Date: Fri, 2 May 2008 13:21:24 +0800 (CST) [thread overview]
Message-ID: <alpine.LFD.1.10.0805021319200.3349@localhost.localdomain> (raw)
In-Reply-To: <20080501011123.GA4060@gondor.apana.org.au>
On Thu, 1 May 2008, Herbert Xu wrote:
> On Thu, May 01, 2008 at 12:06:55AM +0800, WANG Cong wrote:
>>
>> Hi, Herbert.
>>
>> I referenced the book Linux Device Drivers, it is said that
>> the work function in workqueue can sleep, that is to say, it only
>> works in process context, so we don't need the disable the lock
>> in softirq, which is interrupt context, right?
>
> Because it can sleep, you must disable BH for locks that can
> be taken on the softirq path as otherwise a softirq can come
> in, try to take the lock again and dead-lock.
Yes, I was an idiot.
I will resend the revised patches right now.
next prev parent reply other threads:[~2008-05-02 5:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 15:55 [Patch]net/xfrm/xfrm_policy.c: replace timer with delayed_work WANG Cong
2008-04-27 1:18 ` Herbert Xu
2008-04-28 14:53 ` WANG Cong
2008-04-28 15:13 ` Herbert Xu
2008-04-30 16:06 ` WANG Cong
2008-05-01 1:11 ` Herbert Xu
2008-05-02 5:21 ` WANG Cong [this message]
2008-05-02 5:35 ` [Patch] (revised) net/xfrm/xfrm_policy.c: " WANG Cong
2008-05-02 23:54 ` David Miller
2008-05-03 14:46 ` WANG Cong
2008-05-03 15:06 ` Herbert Xu
2008-05-03 15:31 ` WANG Cong
2008-05-04 1:38 ` David Miller
2008-05-04 1:37 ` David Miller
2008-05-06 3:08 ` Herbert Xu
2008-05-06 3:57 ` WANG Cong
2008-05-02 5:43 ` [Patch](Revised) net/xfrm/xfrm_state.c: " WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805021319200.3349@localhost.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).