Netdev List
 help / color / mirror / Atom feed
From: Nicolas Pitre <nico@cam.org>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
	linux-netdev <netdev@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Eric Miao <eric.miao@marvell.com>
Subject: Re: [PATCH 07/10] pxa: make lubbock to use new smc91x platform data
Date: Thu, 26 Jun 2008 20:02:21 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0806262002020.2979@xanadu.home> (raw)
In-Reply-To: <1214300867-15495-8-git-send-email-eric.y.miao@gmail.com>

On Tue, 24 Jun 2008, Eric Miao wrote:

> From: Eric Miao <eric.miao@marvell.com>
> 
> Signed-off-by: Eric Miao <eric.miao@marvell.com>

Acked-by: Nicolas Pitre <nico@cam.org>

> ---
>  arch/arm/mach-pxa/lubbock.c |    8 ++++++++
>  drivers/net/smc91x.h        |    3 +--
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/lubbock.c b/arch/arm/mach-pxa/lubbock.c
> index 429e197..423c883 100644
> --- a/arch/arm/mach-pxa/lubbock.c
> +++ b/arch/arm/mach-pxa/lubbock.c
> @@ -21,6 +21,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/mtd/mtd.h>
>  #include <linux/mtd/partitions.h>
> +#include <linux/smc91x.h>
>  
>  #include <linux/spi/spi.h>
>  #include <linux/spi/ads7846.h>
> @@ -335,11 +336,18 @@ static struct resource smc91x_resources[] = {
>  	},
>  };
>  
> +static struct smc91x_platdata lubbock_smc91x_info = {
> +	.flags	= SMC91X_USE_16BIT | SMC91X_NOWAIT | SMC91X_IO_SHIFT_2,
> +};
> +
>  static struct platform_device smc91x_device = {
>  	.name		= "smc91x",
>  	.id		= -1,
>  	.num_resources	= ARRAY_SIZE(smc91x_resources),
>  	.resource	= smc91x_resources,
> +	.dev		= {
> +		.platform_data = &lubbock_smc91x_info,
> +	},
>  };
>  
>  static struct resource flash_resources[] = {
> diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
> index 208dfc8..95ee9ed 100644
> --- a/drivers/net/smc91x.h
> +++ b/drivers/net/smc91x.h
> @@ -48,8 +48,7 @@
>  #define SMC_CAN_USE_32BIT	0
>  #define SMC_NOWAIT		1
>  
> -/* The first two address lines aren't connected... */
> -#define SMC_IO_SHIFT		2
> +#define SMC_IO_SHIFT		smc_io_shift
>  
>  #define SMC_inw(a, r)		readw((a) + (r))
>  #define SMC_outw(v, a, r)	writew(v, (a) + (r))
> -- 
> 1.5.4.3
> 


Nicolas

      reply	other threads:[~2008-06-27  0:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24  9:47 [PATCH 07/10] pxa: make lubbock to use new smc91x platform data Eric Miao
2008-06-27  0:02 ` Nicolas Pitre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0806262002020.2979@xanadu.home \
    --to=nico@cam.org \
    --cc=eric.miao@marvell.com \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox