From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG
Date: Fri, 3 Oct 2008 21:38:44 +0200 (CEST)
Message-ID: <alpine.LFD.2.00.0810032137390.4573@apollo>
References: <20081002233314.12556.49143.stgit@jbrandeb-bw.jf.intel.com> <20081002233340.12556.33137.stgit@jbrandeb-bw.jf.intel.com> <Pine.LNX.4.64.0810031346100.1532@twin.jikos.cz> <alpine.LFD.2.00.0810030812570.3230@nehalem.linux-foundation.org>
 <alpine.LNX.1.10.0810031736150.26779@jikos.suse.cz>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	arjan@linux.intel.com, airlied@gmail.com, davem@davemloft.net,
	Jeff Garzik <jeff@garzik.org>
To: Jiri Kosina <jkosina@suse.cz>
Return-path: <netdev-owner@vger.kernel.org>
Received: from www.tglx.de ([62.245.132.106]:47639 "EHLO www.tglx.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752475AbYJCTjP (ORCPT <rfc822;netdev@vger.kernel.org>);
	Fri, 3 Oct 2008 15:39:15 -0400
In-Reply-To: <alpine.LNX.1.10.0810031736150.26779@jikos.suse.cz>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 3 Oct 2008, Jiri Kosina wrote:
> On Fri, 3 Oct 2008, Linus Torvalds wrote:
> 
> > > The debugging message is racy anyway with respect to accessing 
> > > nvm_owner, right? It should be done after the mutex has been 
> > > succesfully acquired.
> > It's done that way on purpose - to see who _could_ be racing.
> 
> I know. I just wanted to point out that we probably don't want the patch 
> in 2.6.27 in this form, users wouldn't like to have warning in their logs 
> every time mutex is not acquired on a first attempt :)

Yeah, it should go before .27 final. It now just gathers data as
people actually care about warn_ons or they are even caught
automatically via kernel oops.

Thanks,

	tglx