From: Thomas Gleixner <tglx@linutronix.de>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2]: pkt_sched: Convert CBQ to tasklet_hrtimer.
Date: Fri, 28 Aug 2009 21:51:40 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0908282147550.19335@localhost.localdomain> (raw)
In-Reply-To: <20090828.123035.192913179.davem@davemloft.net>
On Fri, 28 Aug 2009, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 28 Aug 2009 17:54:53 +0200
>
> > I now have these dmesg warnings when playing with cbq
> >
> > # tc qdisc del dev eth3 root
> > # tc qdisc add dev eth3 root handle 1: est 1sec 8sec cbq avpkt 1000 rate 1000Mbit bandwidth 1000Mbit
> > # tc qdisc del dev eth3 root
> >
> > [12786.458485] Attempt to kill tasklet from interrupt
> > [12786.458522] Attempt to kill tasklet from interrupt
> > [12786.465261] Attempt to kill tasklet from interrupt
> > [12786.465286] Attempt to kill tasklet from interrupt
> >
> > probably becauce cbq_reset() being called from interrupt context ?
>
> Grumble... I guess the tasklet_hrtimer infrastructure is less
> of a direct plugin replacement for plain hrtimers than I thought.
>
> Anyone have any ideas about how to deal with stuff like this?
Hmm. Is it sufficient to cancel just the timer and let an eventually
scheduled tasklet deal with the cleanup ?
Thanks,
tglx
prev parent reply other threads:[~2009-08-28 19:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-22 0:03 [PATCH 2/2]: pkt_sched: Convert CBQ to tasklet_hrtimer David Miller
2009-08-22 9:17 ` Thomas Gleixner
2009-08-23 1:08 ` David Miller
2009-08-23 7:22 ` Thomas Gleixner
2009-08-24 1:54 ` David Miller
2009-08-28 15:54 ` Eric Dumazet
2009-08-28 19:30 ` David Miller
2009-08-28 19:51 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0908282147550.19335@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox