From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Joe Perches <joe@perches.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: RE: [PATCH] drivers/net/defxx.c: use %pMF to show MAC address
Date: Fri, 8 Jan 2010 13:34:34 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.00.1001081316570.13474@eddie.linux-mips.org> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090208961F@mi8nycmail19.Mi8.com>
On Thu, 7 Jan 2010, H Hartley Sweeten wrote:
> >> I believe the output will _now_ be in the canonical form.
> >> Before it wasn't bit reversed. Now it should be.
> >
> > Output was correct -- why would you assume otherwise? The bit order in
> > the MLA (My Long Address) register as retrieved from the MAC chip by
> > board's firmware has nothing to do with the wire order and is already in
> > the canonical form (the same applies to CAM entries and frame headers) --
> > the board designers were sane people.
> >
> > With the two patches in place the output produced is now broken. :(
> >
>
> Ugh.. This is a mess...
>
> David,
>
> Can you please un-apply both this patch and the one for skfddi.c?
> I think they should both use some form of the %p[mMF] format to display
> the address but it appears Maciej is the only person that really knows
> what the output _should" be...
Here are excerpts from old bootstrap logs -- I don't have any of these
boards handy at the moment, but I'll have access to a couple in a few
weeks' time:
defxx: v1.10 2006/12/14 Lawrence V. Stefani and others
tc0: DEFTA at addr = 0x10100000, IRQ = 2, Hardware addr = 08-00-2B-A3-66-C8
tc0: registered as fddi0
tc1: DEFTA at addr = 0x14100000, IRQ = 3, Hardware addr = 08-00-2B-A3-A3-29
tc1: registered as fddi1
defxx: v1.10 2006/12/14 Lawrence V. Stefani and others
0000:00:06.0: DEFPA at addr = 0x41071000, IRQ = 57, Hardware addr = 00-60-B0-58-40-75
0000:00:06.0: registered as fddi0
0000:02:00.0: DEFPA at addr = 0x41510000, IRQ = 57, Hardware addr = 00-60-B0-58-41-E7
0000:02:00.0: registered as fddi1
Compare the addresses reported with the OUIs of the respective
manufacturers -- the former is DEC and the latter is HP. See
http://standards.ieee.org/regauth/oui/oui.txt for a reference.
Maciej
next prev parent reply other threads:[~2010-01-08 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 23:24 [PATCH] drivers/net/defxx.c: use %pMF to show MAC address H Hartley Sweeten
2010-01-08 0:58 ` David Miller
2010-01-08 1:39 ` Joe Perches
2010-01-08 2:06 ` Maciej W. Rozycki
2010-01-08 2:11 ` H Hartley Sweeten
2010-01-08 7:47 ` David Miller
2010-01-08 13:34 ` Maciej W. Rozycki [this message]
2010-01-08 17:54 ` Joe Perches
2010-01-08 18:58 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001081316570.13474@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).