From: Thomas Gleixner <tglx@linutronix.de>
To: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"arjan@linux.jf.intel.com" <arjan@linux.jf.intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC: linux-next 1/2] irq: Add CPU mask affinity hint callback framework
Date: Thu, 29 Apr 2010 22:39:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1004292237280.2951@localhost.localdomain> (raw)
In-Reply-To: <1272572930.9614.3.camel@localhost>
On Thu, 29 Apr 2010, Peter P Waskiewicz Jr wrote:
> On Thu, 2010-04-29 at 12:48 -0700, Thomas Gleixner wrote:
> > Thinking more about it, I wonder whether you have a cpu_mask in your
> > driver/device private data anyway. I bet you have :)
>
> Well, at this point we don't, but nothing says we can't.
Somewhere you need to store that information in your driver, right ?
> > So it should be sufficient to set a pointer to that cpu_mask in
> > irq_desc and get rid of the callback completely.
>
> So "register" would just assign the pointer, and "unregister" would make
> sure to NULL the mask pointer out. I like it. It'll sure clean things
> up too.
Yep, that'd be like the set_irq_chip() function. Just assign the
pointer under desc->lock.
Thanks,
tglx
next prev parent reply other threads:[~2010-04-30 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 4:57 [PATCH RFC: linux-next 1/2] irq: Add CPU mask affinity hint callback framework Peter P Waskiewicz Jr
2010-04-19 4:58 ` [PATCH RFC: linux-next 2/2] ixgbe: Example usage of the new IRQ affinity_hint callback Peter P Waskiewicz Jr
2010-04-21 2:28 ` [PATCH RFC: linux-next 1/2] irq: Add CPU mask affinity hint callback framework David Miller
2010-04-27 12:32 ` Thomas Gleixner
2010-04-27 16:04 ` Peter P Waskiewicz Jr
2010-04-28 16:45 ` Thomas Gleixner
2010-04-29 17:59 ` Peter P Waskiewicz Jr
2010-04-29 19:48 ` Thomas Gleixner
2010-04-29 20:28 ` Peter P Waskiewicz Jr
2010-04-29 20:39 ` Thomas Gleixner [this message]
2010-04-29 21:29 ` Peter P Waskiewicz Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1004292237280.2951@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=arjan@linux.jf.intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).