Netdev List
 help / color / mirror / Atom feed
From: Julian Anastasov <ja@ssi.bg>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	Kumar Swamy <kswamy@barracuda.com>
Subject: [PATCH] netfilter: avoid double free in nf_reinject
Date: Fri, 5 Aug 2011 13:36:28 +0300 (EEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1108051326300.1494@ja.ssi.bg> (raw)


	NF_STOLEN means skb was already freed

Signed-off-by: Julian Anastasov <ja@ssi.bg>
---

	May be fixes IPVS+ip_queue problem reported by Kumar Swamy:

	http://marc.info/?l=linux-virtual-server&m=131098073717449&w=2

diff -urp v3.0/linux/net/netfilter/nf_queue.c linux/net/netfilter/nf_queue.c
--- v3.0/linux/net/netfilter/nf_queue.c	2011-05-20 10:38:08.000000000 +0300
+++ linux/net/netfilter/nf_queue.c	2011-08-05 13:18:29.755962759 +0300
@@ -312,6 +312,7 @@ void nf_reinject(struct nf_queue_entry *
 		}
 		break;
 	case NF_STOLEN:
+		break;
 	default:
 		kfree_skb(skb);
 	}

             reply	other threads:[~2011-08-05 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05 10:36 Julian Anastasov [this message]
2011-08-08  5:11 ` [PATCH] netfilter: avoid double free in nf_reinject David Miller
2011-08-08 10:13   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1108051326300.1494@ja.ssi.bg \
    --to=ja@ssi.bg \
    --cc=kaber@trash.net \
    --cc=kswamy@barracuda.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox