From: Julian Anastasov <ja@ssi.bg>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] neigh: reduce arp latency
Date: Tue, 9 Aug 2011 20:06:25 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1108091959250.1527@ja.ssi.bg> (raw)
In-Reply-To: <1312904434.2371.39.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Hello,
On Tue, 9 Aug 2011, Eric Dumazet wrote:
> Remove the artificial HZ latency on arp resolution.
>
> Instead of firing a timer in one jiffy (up to 10 ms if HZ=100), lets
> send the ARP message immediately.
>
> @@ -957,7 +964,8 @@ int __neigh_event_send(struct neighbour *neigh, struct sk_buff *skb)
> atomic_set(&neigh->probes, neigh->parms->ucast_probes);
> neigh->nud_state = NUD_INCOMPLETE;
> neigh->updated = jiffies;
> - neigh_add_timer(neigh, now + 1);
> + neigh_add_timer(neigh, now + HZ);
To be correct with old NUD_INCOMPLETE logic may be we can use
max(neigh->parms->retrans_time, HZ/2) here instead of HZ?
> + immediate_probe = true;
> } else {
> neigh->nud_state = NUD_FAILED;
> neigh->updated = jiffies;
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2011-08-09 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 15:40 [PATCH net-next] neigh: reduce arp latency Eric Dumazet
2011-08-09 17:06 ` Julian Anastasov [this message]
2011-08-09 18:15 ` [PATCH v2 " Eric Dumazet
2011-08-12 9:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1108091959250.1527@ja.ssi.bg \
--to=ja@ssi.bg \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox