From: Julian Anastasov <ja@ssi.bg>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, herbert@gondor.hengli.com.au
Subject: Re: [PATCH net-next] ipv4: one more case for non-local saddr in ICMP
Date: Thu, 25 Aug 2011 10:25:31 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1108250842130.1634@ja.ssi.bg> (raw)
In-Reply-To: <20110824.193725.2023779878865246098.davem@davemloft.net>
Hello,
On Wed, 24 Aug 2011, David Miller wrote:
> From: Julian Anastasov <ja@ssi.bg>
> Date: Mon, 15 Aug 2011 19:21:23 +0300 (EEST)
>
> > May be there is one more case that we can avoid using
> > non-local source for ICMP errors: xfrm_lookup, num_xfrms = 0 when
> > reverse "Flow passes untransformed". Avoid using the input route
> > if xfrm_lookup returns same dst.
> >
> > Signed-off-by: Julian Anastasov <ja@ssi.bg>
>
> Julian I'm going to defer on this patch unless you think there is
> a real pressing reason to apply it.
No such reason, it solves a very very rare case.
Regards
--
Julian Anastasov <ja@ssi.bg>
prev parent reply other threads:[~2011-08-25 7:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 16:21 [PATCH net-next] ipv4: one more case for non-local saddr in ICMP Julian Anastasov
2011-08-19 10:43 ` David Miller
2011-08-20 8:20 ` Herbert Xu
2011-08-23 6:34 ` Julian Anastasov
2011-08-23 6:46 ` Herbert Xu
2011-08-25 2:37 ` David Miller
2011-08-25 7:25 ` Julian Anastasov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1108250842130.1634@ja.ssi.bg \
--to=ja@ssi.bg \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox