Re: Connect hangs for a while before returns -1 with ECONNREFUSED on 3.2 for loopback

Eric Dumazet
2012-02-04T21:26:34Z

Le samedi 04 février 2012 à 22:51 +0200, Julian Anastasov a écrit :
> Yes, it is optimized by compiler. I just wanted
> to add a function that has the list of all input parameters
> that are modified by the routing lookup, so that we can
> use it at every place that needs to reuse the fl4. It also
> shows that in ip_route_connect and ip_route_newports
> fl4->daddr and fl4->saddr from previous step are reused
> while the other fields are set with original values.
> For icmp_route_lookup it will help when xfrm_decode_session_reverse
> fills fl4_dec to clarify which fields should be provided
> to __ip_route_output_key because now for me it is not clear
> which fields should be preserved. Currently, only tos is
> provided but if xfrm_decode_session_reverse is changed one
> day to fill oif we have to be specific what happens exactly.
>
> > __ip_route_output_key() always had the possibility to change
> > saddr/daddr, I dont think we have to deal with it.
>
> I rely on the fact that fields that are reused
> do not generate code but it will make the logic visible.
> It will help in case one day we modify the semantics for
> the fl4 fields (input/output type).
>

Fair enough, please submit your patch with proper changelog / credits
then ?

Thanks