Netdev List
 help / color / mirror / Atom feed
From: Julian Anastasov <ja@ssi.bg>
To: Hans Schillstrom <hans.schillstrom@ericsson.com>
Cc: Horms <horms@verge.net.au>, Wensong Zhang <wensong@linux-vs.org>,
	lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org, hans@schillstrom.com
Subject: Re: [PATCH 1/1] export sysctl symbols needed by ip_vs_sync
Date: Mon, 30 Apr 2012 10:47:45 +0300 (EEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1204301034450.1649@ja.ssi.bg> (raw)
In-Reply-To: <1335766430-30528-1-git-send-email-hans.schillstrom@ericsson.com>


	Hello,

On Mon, 30 Apr 2012, Hans Schillstrom wrote:

> To build ip_vs as a module sysctl_rmem_max and sysctl_wmem_max
> needs to be exported.
> The dependency was added by "ipvs: wakeup master thread" patch
> 
> Signed-off-by: Hans Schillstrom <hans.schillstrom@ericsson.com>
> ---
>  net/core/sock.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/net/core/sock.c b/net/core/sock.c
> index 679c5bb..be8fe5d 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -258,7 +258,9 @@ static struct lock_class_key af_callback_keys[AF_MAX];
>  
>  /* Run time adjustable parameters. */
>  __u32 sysctl_wmem_max __read_mostly = SK_WMEM_MAX;
> +EXPORT_SYMBOL(sysctl_wmem_max);
>  __u32 sysctl_rmem_max __read_mostly = SK_RMEM_MAX;
> +EXPORT_SYMBOL(sysctl_rmem_max);
>  __u32 sysctl_wmem_default __read_mostly = SK_WMEM_MAX;
>  __u32 sysctl_rmem_default __read_mostly = SK_RMEM_MAX;
>  
> -- 
> 1.7.2.3

	I see why I missed this error. There is some
inefficiency in the build process. Once, I tested the
netns init problems with CONFIG_IP_VS=y, later switched back
to CONFIG_IP_VS=m without 'make clean' but the ip_vs.ko
is not considered, I still get ip_vs as builtin, not as
module:

# cat net/netfilter/ipvs/modules.builtin
kernel/net/netfilter/ipvs/ip_vs.ko

	Is only 'make clean' a solution for such
y->m change?

Regards

--
Julian Anastasov <ja@ssi.bg>

      reply	other threads:[~2012-04-30  7:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30  6:13 [PATCH 1/1] export sysctl symbols needed by ip_vs_sync Hans Schillstrom
2012-04-30  7:47 ` Julian Anastasov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1204301034450.1649@ja.ssi.bg \
    --to=ja@ssi.bg \
    --cc=hans.schillstrom@ericsson.com \
    --cc=hans@schillstrom.com \
    --cc=horms@verge.net.au \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox