Re: [PATCH] netpoll: Fix carrier detection for drivers that are using phylib

Linus Torvalds
2009-07-09T17:31:38Z

On Thu, 9 Jul 2009, Peter Zijlstra wrote:
>
> So something like (utterly untested and such)

This looks like a good patch. Please make it so - who knows what other
uses of cond_resched() we have in module init routines that might have
deadlocks without it. The netpoll case got fixed, but please just do this.

I'd like to do my system_state movement too (the thing is, when you load
drivers as modules you _will_ have "system_state == SYSTEM_RUNNING", so
any initcall that depends on it being "early boot" is already broken), but
there's no way that patch is appropriate for post-rc2. This one, however,
looks appropriate (modulo getting some testing, of course)

Linus