netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Pitre <nico@fluxnic.net>
To: Mircea Gherzan <mgherzan@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linux@arm.linux.org.uk
Subject: Re: [PATCH] ARM: net: JIT compiler for packet filters
Date: Wed, 21 Dec 2011 10:07:17 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1112211006430.2907@xanadu.home> (raw)
In-Reply-To: <20111221144346.GB3229@swarm.cs.pub.ro>

On Wed, 21 Dec 2011, Mircea Gherzan wrote:

> On Mon, Dec 19, 2011 at 12:42:49PM -0500, Nicolas Pitre wrote:
> > On Mon, 19 Dec 2011, Mircea Gherzan wrote:
> > 
> > > +static inline void _emit(int cond, u32 inst, struct jit_ctx *ctx)
> > > +{
> > > +	if (ctx->target != NULL)
> > > +		ctx->target[ctx->idx] = inst | (cond << 28);
> > > +
> > > +	ctx->idx++;
> > > +}
> > 
> > You might consider the patch titled "ARM: Add generic instruction opcode 
> > manipulation helpers" that Dave Martin just posted and rely on it to 
> > make your code compatible with BE8 mode as well.
> 
> That patch is not in devel-stable and I don't want to introduce further
> dependencies for the time being. Once both patches are in mainline, I
> will take a look.

Fair enough.


Nicolas

  reply	other threads:[~2011-12-21 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-18 23:49 [PATCH] ARM: net: JIT compiler for packet filters Mircea Gherzan
2011-12-19  2:26 ` Ben Hutchings
2011-12-19  2:49 ` Rob Herring
2011-12-19 17:31   ` Nicolas Pitre
2011-12-21 14:36     ` Mircea Gherzan
2011-12-19 17:42 ` Nicolas Pitre
2011-12-21 14:43   ` Mircea Gherzan
2011-12-21 15:07     ` Nicolas Pitre [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-12-18 23:48 Mircea Gherzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1112211006430.2907@xanadu.home \
    --to=nico@fluxnic.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mgherzan@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).