From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joseph Gasparakis Subject: Re: [net-next v3 06/16] i40e: Implementation of vxlan ndo's Date: Fri, 20 Dec 2013 18:14:46 -0800 (PST) Message-ID: References: <20131220.164915.1182500137355120095.davem@davemloft.net> <20131220.204105.425672139698438176.davem@davemloft.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "Gasparakis, Joseph" , "or.gerlitz@gmail.com" , "Kirsher, Jeffrey T" , "netdev@vger.kernel.org" , "gospo@redhat.com" , "sassmann@redhat.com" , "Brandeburg, Jesse" To: David Miller Return-path: Received: from mga14.intel.com ([143.182.124.37]:26872 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214Ab3LUB5D (ORCPT ); Fri, 20 Dec 2013 20:57:03 -0500 In-Reply-To: <20131220.204105.425672139698438176.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 20 Dec 2013, David Miller wrote: > From: Joseph Gasparakis > Date: Fri, 20 Dec 2013 15:25:44 -0800 (PST) > > > Right now the code in vxlan.h is: > > > > #if IS_ENABLED(CONFIG_VXLAN) > > void vxlan_get_rx_port(struct net_device *netdev); > > #else > > static inline void vxlan_get_rx_port(struct net_device *netdev) > > { > > } > > #endif > > > > so the function can be called from drivers whether vxlan is enabled in > > .config or not. However, the "depends on VXLAN || !VXLAN" is needed when > > the driver is compiled as a built-in, otherwise we get an undefined > > reference for the above function. If this is not the right way to fix the > > dependency please let me know and I will fix it accordingly. > > Ok, can you write this with the more canonical: > > (X || X=n) > > That's how we write it out to handle the same issue with > IPV6. > > Thanks. Will do. Thanks. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >