From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Joe Perches <joe@perches.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] declance: Fix 64-bit compilation warnings
Date: Sat, 5 Jul 2014 19:20:48 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.11.1407051917480.15455@eddie.linux-mips.org> (raw)
In-Reply-To: <1404583739.6384.51.camel@joe-AO725>
On Sat, 5 Jul 2014, Joe Perches wrote:
> > > I think it's a mistake and I agree.
> > >
> > > I submitted a patch to remove the prefix from %pad.
> > >
> > > https://lkml.org/lkml/2014/3/21/333
> >
> > Great! Your proposal looks good to me in principle, however you need to
> > factor in SPECIAL having been set by `#' somehow as `number' will respect
> > it. I suggest using the same field width calculation that `pointer' uses
> > for `default_width' (sans the type used with `sizeof' of course, that is).
>
> I don't think %#p is valid so it
> shouldn't have been set by #.
Huh? As recently as last Wednesday you pointed me at the specific commit
from Grant that made it valid (GCC format complaints aside).
Maciej
next prev parent reply other threads:[~2014-07-05 18:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 2:10 [PATCH v2] declance: Fix 64-bit compilation warnings Maciej W. Rozycki
2014-07-03 1:28 ` David Miller
2014-07-03 2:29 ` Maciej W. Rozycki
2014-07-03 2:34 ` Maciej W. Rozycki
2014-07-03 3:05 ` Joe Perches
2014-07-03 4:51 ` Maciej W. Rozycki
2014-07-03 5:16 ` Joe Perches
2014-07-03 6:01 ` Maciej W. Rozycki
2014-07-03 6:25 ` Joe Perches
2014-07-03 16:57 ` Grant Likely
2014-07-05 14:56 ` Maciej W. Rozycki
2014-07-05 16:07 ` Joe Perches
2014-07-05 17:39 ` Maciej W. Rozycki
2014-07-05 18:08 ` Joe Perches
2014-07-05 18:20 ` Maciej W. Rozycki [this message]
2014-07-05 18:31 ` Joe Perches
2014-07-05 20:25 ` Maciej W. Rozycki
2014-07-05 20:45 ` [PATCH] vsprintf: Remove SPECIAL from pointer types Joe Perches
2014-07-06 11:44 ` Maciej W. Rozycki
2014-07-06 14:32 ` Joe Perches
2014-07-07 8:26 ` David Laight
2014-07-07 13:26 ` Joe Perches
2014-07-07 12:01 ` [PATCH v2] declance: Fix 64-bit compilation warnings Grant Likely
2014-07-07 12:18 ` Maciej W. Rozycki
2014-07-07 13:40 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1407051917480.15455@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).