* drivers/net/ethernet/atheros/atlx/atl2.c uses dead MODULE_PARM
@ 2018-08-11 10:05 Robert P. J. Day
0 siblings, 0 replies; only message in thread
From: Robert P. J. Day @ 2018-08-11 10:05 UTC (permalink / raw)
To: Linux kernel netdev mailing list; +Cc: jcliburn, chris.snook
just noticed this in that ATLX source file:
#ifndef module_param_array
/* Module Parameters are always initialized to -1, so that the driver
* can tell the difference between no user specified value or the
* user asking for the default value.
* The true default values are loaded in when atl2_check_options is called.
*
* This is a GCC extension to ANSI C.
* See the item "Labeled Elements in Initializers" in the section
* "Extensions to the C Language Family" of the GCC documentation.
*/
#define ATL2_PARAM(X, desc) \
static const int X[ATL2_MAX_NIC + 1] = ATL2_PARAM_INIT; \
MODULE_PARM(X, "1-" __MODULE_STRING(ATL2_MAX_NIC) "i"); \
... snip ...
the macro "MODULE_PARM" isn't even defined anymore, so that usage of
MODULE_PARM is not going to work well if the C preprocessor ever gets
ahold of it.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-08-11 12:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-11 10:05 drivers/net/ethernet/atheros/atlx/atl2.c uses dead MODULE_PARM Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).