From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Robert P. J. Day" Subject: drivers/net/ethernet/atheros/atlx/atl2.c uses dead MODULE_PARM Date: Sat, 11 Aug 2018 06:05:25 -0400 (EDT) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: jcliburn@gmail.com, chris.snook@gmail.com To: Linux kernel netdev mailing list Return-path: Received: from cpanel4.indieserve.net ([199.212.143.9]:36046 "EHLO cpanel4.indieserve.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727205AbeHKMky (ORCPT ); Sat, 11 Aug 2018 08:40:54 -0400 Sender: netdev-owner@vger.kernel.org List-ID: just noticed this in that ATLX source file: #ifndef module_param_array /* Module Parameters are always initialized to -1, so that the driver * can tell the difference between no user specified value or the * user asking for the default value. * The true default values are loaded in when atl2_check_options is called. * * This is a GCC extension to ANSI C. * See the item "Labeled Elements in Initializers" in the section * "Extensions to the C Language Family" of the GCC documentation. */ #define ATL2_PARAM(X, desc) \ static const int X[ATL2_MAX_NIC + 1] = ATL2_PARAM_INIT; \ MODULE_PARM(X, "1-" __MODULE_STRING(ATL2_MAX_NIC) "i"); \ ... snip ... the macro "MODULE_PARM" isn't even defined anymore, so that usage of MODULE_PARM is not going to work well if the C preprocessor ever gets ahold of it. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca/dokuwiki Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================