From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Robert P. J. Day" Subject: Re: confusing comment, explanation of @IFF_RUNNING in if.h Date: Sun, 26 Aug 2018 15:30:45 -0400 (EDT) Message-ID: References: <20180826192001.GC7359@lunn.ch> <20180826192854.GE7359@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Linux kernel netdev mailing list To: Andrew Lunn Return-path: Received: from cpanel4.indieserve.net ([199.212.143.9]:47342 "EHLO cpanel4.indieserve.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726625AbeHZXQl (ORCPT ); Sun, 26 Aug 2018 19:16:41 -0400 In-Reply-To: <20180826192854.GE7359@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 26 Aug 2018, Andrew Lunn wrote: > On Sun, Aug 26, 2018 at 03:20:24PM -0400, Robert P. J. Day wrote: > > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > > > i ask since, in my testing, when the interface should have been > > > > up, the attribute file "operstate" for that interface showed > > > > "unknown", and i wondered how worried i should be about that. > > > > > > Hi Robert > > > > > > You should probably post the driver for review. A well written > > > driver should not even need to care about any of this. phylib and > > > the netdev driver code does all the work. It only gets interesting > > > when you don't have a PHY, e.g. a stacked device, like bonding, or a > > > virtual device like tun/tap. > > > > i wish, but i'm on contract, and proprietary, and NDA and all that. > > so i am reduced to crawling through the code, trying to figure out > > what is misconfigured that is causing all this grief. > > I would say proprietary and NDA is causing you all this grief. > > There is also the point that if you are not going to contribute the > code to mainline, why should we help you? > > The code is GPL after all, so you can post it. i'm confident that it will *eventually* be GPLed (i can't imagine there is any other outcome), but for now, there's nothing i can do. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca/dokuwiki Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================