From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Yang Wei <albin_yang@163.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
yang.wei9@zte.com.cn
Subject: Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
Date: Tue, 5 Feb 2019 19:57:34 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.1902051816130.9991@eddie.linux-mips.org> (raw)
In-Reply-To: <1549382464-5138-1-git-send-email-albin_yang@163.com>
On Wed, 6 Feb 2019, Yang Wei wrote:
> From: Yang Wei <yang.wei9@zte.com.cn>
>
> dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
> xmit done. It makes drop profiles(dropwatch, perf) more friendly.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>
It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs
`kfree_skb' use too. I'll have a look into it unless you are happy to do
that.
Thanks for your contribution!
Maciej
next prev parent reply other threads:[~2019-02-05 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 16:01 [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
2019-02-05 19:57 ` Maciej W. Rozycki [this message]
2019-02-06 15:13 ` albin_yang
2019-02-07 1:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1902051816130.9991@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=albin_yang@163.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yang.wei9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).