From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Cfxk=QM=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 15991C282CB
	for <netdev@archiver.kernel.org>; Tue,  5 Feb 2019 19:57:38 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E5DD62083B
	for <netdev@archiver.kernel.org>; Tue,  5 Feb 2019 19:57:37 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730073AbfBET5g (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 5 Feb 2019 14:57:36 -0500
Received: from eddie.linux-mips.org ([148.251.95.138]:41552 "EHLO
        cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726927AbfBET5g (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Feb 2019 14:57:36 -0500
Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org
        with ESMTP id S23991082AbfBET5eUvrg2 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Feb 2019 20:57:34 +0100
Date:   Tue, 5 Feb 2019 19:57:34 +0000 (GMT)
From:   "Maciej W. Rozycki" <macro@linux-mips.org>
To:     Yang Wei <albin_yang@163.com>
cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        yang.wei9@zte.com.cn
Subject: Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by
 dev_consume_skb_irq for drop profiles
In-Reply-To: <1549382464-5138-1-git-send-email-albin_yang@163.com>
Message-ID: <alpine.LFD.2.21.1902051816130.9991@eddie.linux-mips.org>
References: <1549382464-5138-1-git-send-email-albin_yang@163.com>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, 6 Feb 2019, Yang Wei wrote:

> From: Yang Wei <yang.wei9@zte.com.cn>
> 
> dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
> xmit done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>

Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>

 It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs 
`kfree_skb' use too.  I'll have a look into it unless you are happy to do 
that.

 Thanks for your contribution!

  Maciej