Re: [RFC PATCH v2] Gemini: Gigabit ethernet driver

[Hans Ulli Kroll <ulli.kroll@googlemail.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1213 bytes --]



On Mon, 27 Dec 2010, Michał Mirosław wrote:

> Driver for SL351x (Gemini) SoC ethernet peripheral. Based in part
> on work by Paulius Zaleckas and GPLd code from Raidsonic and other
> NAS vendors.
> 
> Tested on Raidsonic IcyBox 4220-B (dual SATA NAS).
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> 
> ---
> 
> Hans, please drop previous mail from the gemini-board-dev queue -
> it had broken headers.

mail is already out.

> +		.dis_tx = 1,
> +		.dis_rx = 1,
> +		.max_len = 2,	/* magic; 512 << max_len? */
> +		.ipv4_rx_chksum = 1,
> +		.ipv6_rx_chksum = 1,

This is what I found in some netbsd code for maxlen

#define	CONFIG0_MAXLEN_MASK			__BITS(8,10)
#define	CONFIG0_MAXLEN_GET(x)			(((x) >> 8) & 
CONFIG0_MAXLEN_MASK)
#define	CONFIG0_MAXLEN(x)			(((x) & 
CONFIG0_MAXLEN_MASK) << 8)
#define	CONFIG0_MAXLEN_1536			0
#define	CONFIG0_MAXLEN_1518			1
#define	CONFIG0_MAXLEN_1522			2
#define	CONFIG0_MAXLEN_1548			3
#define	CONFIG0_MAXLEN_JUMBO			4

spec. for the SL3616 says jumbo is 9k frames, but i didn't proved this.

BTW:

Why u64_stats ?
I see only a few driver are using u64_stats.
vlan, br_device and some intel driver 
no gigabit driver for marvell devices uses u64_stats

Ulli