From: Hans Ulli Kroll <ulli.kroll@googlemail.com>
To: Stephen Hemminger <stephen.hemminger@vyatta.com>
Cc: "Ben Hutchings" <bhutchings@solarflare.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
gemini-board-dev@lists.berlios.de, netdev@vger.kernel.org,
"Christoph Biedl" <linux-kernel.bfrz@manchmal.in-ulm.de>,
"Hans Ulli Kroll" <ulli.kroll@googlemail.com>
Subject: Re: [RFC PATCH v2] Gemini: Gigabit ethernet driver
Date: Wed, 29 Dec 2010 17:56:58 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1012291750060.9177@localhost> (raw)
In-Reply-To: <1202721929.17594.1293513142947.JavaMail.root@tahiti.vyatta.com>
On Mon, 27 Dec 2010, Stephen Hemminger wrote:
>
>
> ----- Original Message -----
> > On Mon, 2010-12-27 at 20:21 +0100, Hans Ulli Kroll wrote:
> > [...]
> > > BTW:
> > >
> > > Why u64_stats ?
> > > I see only a few driver are using u64_stats.
> > > vlan, br_device and some intel driver
> > > no gigabit driver for marvell devices uses u64_stats
> >
> > All new net drivers should implement 64-bit stats. net_device_stats is
> > kept for backward compatibility because we couldn't change all the
> > existing drivers at once (it's not a simple change for all of them).
> >
> > Ben.
>
> BS. drivers with old stats are fine. 64 bit only really matters
> at higher speed. Anyway, it is the kind of thing that can easily
> be fixed later after driver is merged.
>
>
I've readed the Intel driver.
So we must also implement to old net_stats interface, for backward
compatibility ?
Ulli
next prev parent reply other threads:[~2010-12-29 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 10:32 [RFC PATCH v2] Gemini: Gigabit ethernet driver Michał Mirosław
2010-12-27 19:21 ` Hans Ulli Kroll
2010-12-28 4:37 ` Ben Hutchings
2010-12-28 5:12 ` Stephen Hemminger
2010-12-29 16:56 ` Hans Ulli Kroll [this message]
2010-12-29 18:30 ` Eric Dumazet
2010-12-29 19:28 ` Stephen Hemminger
2010-12-29 19:52 ` Eric Dumazet
2010-12-29 19:57 ` Stephen Hemminger
2010-12-29 21:42 ` Ben Hutchings
2010-12-28 11:45 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1012291750060.9177@localhost \
--to=ulli.kroll@googlemail.com \
--cc=bhutchings@solarflare.com \
--cc=gemini-board-dev@lists.berlios.de \
--cc=linux-kernel.bfrz@manchmal.in-ulm.de \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).