From: Hans Ulli Kroll <ulli.kroll@googlemail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>,
gemini-board-dev@lists.berlios.de, netdev@vger.kernel.org,
Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de>
Subject: Re: [PATCH v4] Gemini: Gigabit ethernet driver
Date: Thu, 30 Dec 2010 12:48:47 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1012301236400.18031@localhost> (raw)
In-Reply-To: <20101230083905.5A8EB13909@rere.qmqm.pl>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 865 bytes --]
On Thu, 30 Dec 2010, Michał Mirosław wrote:
> Driver for SL351x (Gemini) SoC ethernet peripheral. Based in part
> on work by Paulius Zaleckas and GPLd code from Raidsonic and other
> NAS vendors.
>
> Tested on Raidsonic IcyBox 4220-B (dual SATA NAS).
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
>
Hi Michał,
I've make a quick compile and run test on my IB4220
Looks good.
But we must include the file gmac.h from
arch/arm/mach-gemini/include/mach.
We break the build, if we don't do this.
Other issue is the __raw_writel and __raw_readl functions, we can switch
to readl and writel. This is due some mistake of the original developer
(Stormlinksemi) who doesn't understand endianes on ARM
I've tested this driver on my IB4220 only in 100MBit/s mode. PHY is broken.
I have another IB4220 at my home with working PHY
Ulli
next prev parent reply other threads:[~2010-12-30 11:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 13:02 [PATCH v3] Gemini: Gigabit ethernet driver Michał Mirosław
2010-12-30 8:39 ` [PATCH v4] " Michał Mirosław
2010-12-30 9:19 ` Joe Perches
2010-12-30 9:48 ` Michał Mirosław
2010-12-30 11:48 ` Hans Ulli Kroll [this message]
2011-01-26 23:24 ` [PATCH v5] " Michał Mirosław
2011-01-28 22:31 ` David Miller
2011-02-02 17:18 ` Michał Mirosław
2011-02-05 13:19 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1012301236400.18031@localhost \
--to=ulli.kroll@googlemail.com \
--cc=gemini-board-dev@lists.berlios.de \
--cc=linux-kernel.bfrz@manchmal.in-ulm.de \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).