From: malc <av1474@comtv.ru>
To: Vladimir Murzin <murzin.v@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, kaffeemonster@googlemail.com,
edumazet@google.com, mingo@redhat.com, tglx@linutronix.de
Subject: Re: [PATCH 2/3] net: bpf jit: x86: optimize choose_load_func error path
Date: Sun, 13 Oct 2013 18:25:34 +0400 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.00.1310131824180.2262@linmac> (raw)
In-Reply-To: <20131013142115.GA1872@hp530>
On Sun, 13 Oct 2013, Vladimir Murzin wrote:
> On Fri, Oct 11, 2013 at 02:56:13PM -0400, David Miller wrote:
> > From: Vladimir Murzin <murzin.v@gmail.com>
> > Date: Tue, 8 Oct 2013 20:31:49 +0400
> >
[..snip..]
> -common_load: seen |= SEEN_DATAREF;
> +common_load:
> + if (!func) {
> + CLEAR_A();
> + EIT_JMP(cleanup_addr - addrs[i]);
EMIT? (likewise elsewhere)
> + break;
> + }
> +
> + seen |= SEEN_DATAREF;
> t_offset = func - (image + addrs[i]);
> EMIT1_off32(0xbe, K); /* mov imm32,%esi */
> EMIT1_off32(0xe8, t_offset); /* call */
> @@ -624,6 +631,13 @@ common_load: seen |= SEEN_DATAREF;
> goto common_load;
> case BPF_S_LDX_B_MSH:
> func = CHOOSE_LOAD_FUNC(K, sk_load_byte_msh);
> +
> + if (!func) {
> + CLEAR_A();
> + EIT_JMP(cleanup_addr - addrs[i]);
> + break;
> + }
> +
> seen |= SEEN_DATAREF | SEEN_XREG;
> t_offset = func - (image + addrs[i]);
> EMIT1_off32(0xbe, K); /* mov imm32,%esi */
>
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2013-10-13 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 16:31 [PATCH 1/3] net: bpf jit: ppc: optimize choose_load_func error path Vladimir Murzin
2013-10-08 22:50 ` Jan Seiffert
2013-10-13 14:26 ` Vladimir Murzin
[not found] ` <1381249910-17338-2-git-send-email-murzin.v@gmail.com>
2013-10-11 18:56 ` [PATCH 2/3] net: bpf jit: x86: " David Miller
2013-10-13 14:21 ` Vladimir Murzin
2013-10-13 14:25 ` malc [this message]
2013-10-13 14:31 ` Vladimir Murzin
2013-10-13 14:54 ` Vladimir Murzin
2013-10-13 14:54 ` Vladimir Murzin
2013-10-13 16:36 ` Eric Dumazet
2013-10-14 2:55 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1310131824180.2262@linmac \
--to=av1474@comtv.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kaffeemonster@googlemail.com \
--cc=mingo@redhat.com \
--cc=murzin.v@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox