From mboxrd@z Thu Jan 1 00:00:00 1970 From: Enrico Mioso Subject: Re: [PATCH V3 2/2] Introduce huawei_cdc_ncm driver Date: Wed, 3 Jul 2013 20:11:39 +0200 (CEST) Message-ID: References: <87wqp9xja5.fsf@nemi.mork.no> <871u7gvz2z.fsf@nemi.mork.no> <51D424D1.2010507@cogentembedded.com> <1372868333.1919.3.camel@bwh-desktop.uk.level5networks.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Enrico Mioso , Sergei Shtylyov , netdev@vger.kernel.org To: Ben Hutchings Return-path: Received: from mail-wi0-f181.google.com ([209.85.212.181]:54536 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755944Ab3GCSLT (ORCPT ); Wed, 3 Jul 2013 14:11:19 -0400 Received: by mail-wi0-f181.google.com with SMTP id hq4so437456wib.2 for ; Wed, 03 Jul 2013 11:11:17 -0700 (PDT) In-Reply-To: <1372868333.1919.3.camel@bwh-desktop.uk.level5networks.com> Sender: netdev-owner@vger.kernel.org List-ID: Thank you Ben !! :) Applying... On Wed, 3 Jul 2013, Ben Hutchings wrote: ==Date: Wed, 3 Jul 2013 17:18:53 +0100 ==From: Ben Hutchings ==To: Enrico Mioso ==Cc: Sergei Shtylyov , == netdev@vger.kernel.org ==Subject: Re: [PATCH V3 2/2] Introduce huawei_cdc_ncm driver == ==On Wed, 2013-07-03 at 15:38 +0200, Enrico Mioso wrote: ==> This new driver, handles devices that mimic the NCM standard, but using NCM as ==> a transport layer to encapsulate other protocols (i.e. AT protocol). ==> ==> Signed-off-by: Enrico Mioso == ==Add a '---' separator here, between the commit message and the list of ==changes that doesn't need to go in the commit message. == ==> V3: ==> - fixed typo in Kconfig (help text) ==> ==> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig ==> index 287cc62..33cb175 100644 ==> --- a/drivers/net/usb/Kconfig ==> +++ b/drivers/net/usb/Kconfig ==> @@ -246,6 +246,18 @@ config USB_NET_CDC_NCM ==> * ST-Ericsson M343 HSPA Mobile Broadband Modem (reference design) ==> * Ericsson F5521gw Mobile Broadband Module ==> ==> +config USB_NET_HUAWEI_CDC_NCM ==> + tristate "Huawei-style CDC NCM support" ==> + depends on USB_USBNET ==> + default y ==> + select USB_WDM ==> + select USB_NET_CDC_NCM ==[...] == ==The new config symbol should either depend on USB_NET_CDC_NCM (rather ==than selecting it), or have no default setting. It is not correct to ==enable it by default just because USB_USBNET is selected. == ==Ben. == ==-- ==Ben Hutchings, Staff Engineer, Solarflare ==Not speaking for my employer; that's the marketing department's job. ==They asked us to note that Solarflare product names are trademarked. == ==