From: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
To: "Christian Benvenuti (benve)" <benve@cisco.com>,
"Sujith Sankar (ssujith)" <ssujith@cisco.com>,
Tom Herbert <therbert@google.com>,
jeffrey.t.kirsher@intel.com
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 06/17] net: cisco-enic calls skb_get_rxhash
Date: Tue, 26 Nov 2013 17:26:05 +0530 (IST) [thread overview]
Message-ID: <alpine.LNX.2.03.1311261713030.3174@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1311252150050.22983@tomh.mtv.corp.google.com>
On Mon, 25 Nov 2013, Tom Herbert wrote:
> Drivers should call skb_get_rxhash to set the rxhash and its type in an skbuff.
^^^
It should be skb_set_rxhash right? I would like to have 'git log' show
correct information.
Otherwise this patch looks fine for me.
Acked-by: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> ---
> drivers/net/ethernet/cisco/enic/enic_main.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
> index ff78dfa..ea30551 100644
> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> @@ -1036,11 +1036,12 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq,
> skb->protocol = eth_type_trans(skb, netdev);
> skb_record_rx_queue(skb, q_number);
> if (netdev->features & NETIF_F_RXHASH) {
> - skb->rxhash = rss_hash;
> - if (rss_type & (NIC_CFG_RSS_HASH_TYPE_TCP_IPV6_EX |
> - NIC_CFG_RSS_HASH_TYPE_TCP_IPV6 |
> - NIC_CFG_RSS_HASH_TYPE_TCP_IPV4))
> - skb->l4_rxhash = true;
> + skb_set_rxhash(skb, rss_hash,
> + (rss_type & (NIC_CFG_RSS_HASH_TYPE_TCP_IPV6_EX |
> + NIC_CFG_RSS_HASH_TYPE_TCP_IPV6 |
> + NIC_CFG_RSS_HASH_TYPE_TCP_IPV4)) ?
> + RXHASH_TYPE_L4 : RXHASH_TYPE_L3);
> +
> }
>
> if ((netdev->features & NETIF_F_RXCSUM) && !csum_not_calc) {
> --
> 1.8.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-11-26 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 5:51 [PATCH 06/17] net: cisco-enic calls skb_get_rxhash Tom Herbert
2013-11-26 11:56 ` Govindarajulu Varadarajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.03.1311261713030.3174@gmail.com \
--to=govindarajulu90@gmail.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ssujith@cisco.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).