* [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare
@ 2013-12-30 7:40 Ding Tianhong
2013-12-30 8:12 ` Govindarajulu Varadarajan
0 siblings, 1 reply; 3+ messages in thread
From: Ding Tianhong @ 2013-12-30 7:40 UTC (permalink / raw)
To: Christian Benvenuti, Sujith Sankar, Govindarajulu Varadarajan,
Neel Patel, Nishank Trivedi, David S. Miller, Netdev,
linux-kernel@vger.kernel.org
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Christian Benvenuti <benve@cisco.com>
Cc: Sujith Sankar <ssujith@cisco.com>
Cc: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
Cc: Neel Patel <neepatel@cisco.com>
Cc: Nishank Trivedi <nistrive@cisco.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c b/drivers/net/ethernet/cisco/enic/enic_pp.c
index 43464f0..e6a8319 100644
--- a/drivers/net/ethernet/cisco/enic/enic_pp.c
+++ b/drivers/net/ethernet/cisco/enic/enic_pp.c
@@ -162,7 +162,7 @@ static int enic_are_pp_different(struct enic_port_profile *pp1,
return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
pp2->instance_uuid, PORT_UUID_MAX) |
!!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
- !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
+ !ether_addr_equal(pp1->mac_addr, pp2->mac_addr);
}
static int enic_pp_preassociate(struct enic *enic, int vf,
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare
2013-12-30 7:40 [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare Ding Tianhong
@ 2013-12-30 8:12 ` Govindarajulu Varadarajan
2014-01-02 4:09 ` Sujith Sankar (ssujith)
0 siblings, 1 reply; 3+ messages in thread
From: Govindarajulu Varadarajan @ 2013-12-30 8:12 UTC (permalink / raw)
To: Ding Tianhong
Cc: Christian Benvenuti, Sujith Sankar, Govindarajulu Varadarajan,
Neel Patel, Nishank Trivedi, David S. Miller, Netdev,
linux-kernel@vger.kernel.org
On Mon, 30 Dec 2013, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal
> to instead of memcmp.
>
> Cc: Christian Benvenuti <benve@cisco.com>
> Cc: Sujith Sankar <ssujith@cisco.com>
> Cc: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
> Cc: Neel Patel <neepatel@cisco.com>
> Cc: Nishank Trivedi <nistrive@cisco.com>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> ---
> drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c b/drivers/net/ethernet/cisco/enic/enic_pp.c
> index 43464f0..e6a8319 100644
> --- a/drivers/net/ethernet/cisco/enic/enic_pp.c
> +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c
> @@ -162,7 +162,7 @@ static int enic_are_pp_different(struct enic_port_profile *pp1,
> return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
> pp2->instance_uuid, PORT_UUID_MAX) |
> !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
> - !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
> + !ether_addr_equal(pp1->mac_addr, pp2->mac_addr);
> }
>
> static int enic_pp_preassociate(struct enic *enic, int vf,
> --
> 1.8.0
>
looks good for me
Acked-by: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare
2013-12-30 8:12 ` Govindarajulu Varadarajan
@ 2014-01-02 4:09 ` Sujith Sankar (ssujith)
0 siblings, 0 replies; 3+ messages in thread
From: Sujith Sankar (ssujith) @ 2014-01-02 4:09 UTC (permalink / raw)
To: Govindarajulu Varadarajan (gvaradar), Ding Tianhong
Cc: Christian Benvenuti (benve), Govindarajulu Varadarajan,
Neel Patel (neepatel), Nishank Trivedi, David S. Miller, Netdev,
linux-kernel@vger.kernel.org
Looks good.
Acked by: Sujith Sankar <ssujith@cisco.com>
On 30/12/13 1:42 PM, "Govindarajulu Varadarajan (gvaradar)"
<gvaradar@cisco.com> wrote:
>On Mon, 30 Dec 2013, Ding Tianhong wrote:
>
>> Use possibly more efficient ether_addr_equal
>> to instead of memcmp.
>>
>> Cc: Christian Benvenuti <benve@cisco.com>
>> Cc: Sujith Sankar <ssujith@cisco.com>
>> Cc: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
>> Cc: Neel Patel <neepatel@cisco.com>
>> Cc: Nishank Trivedi <nistrive@cisco.com>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>> ---
>> drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c
>>b/drivers/net/ethernet/cisco/enic/enic_pp.c
>> index 43464f0..e6a8319 100644
>> --- a/drivers/net/ethernet/cisco/enic/enic_pp.c
>> +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c
>> @@ -162,7 +162,7 @@ static int enic_are_pp_different(struct
>>enic_port_profile *pp1,
>> return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
>> pp2->instance_uuid, PORT_UUID_MAX) |
>> !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
>> - !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
>> + !ether_addr_equal(pp1->mac_addr, pp2->mac_addr);
>> }
>>
>> static int enic_pp_preassociate(struct enic *enic, int vf,
>> --
>> 1.8.0
>>
>
>looks good for me
>
>Acked-by: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-02 4:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30 7:40 [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare Ding Tianhong
2013-12-30 8:12 ` Govindarajulu Varadarajan
2014-01-02 4:09 ` Sujith Sankar (ssujith)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).