From mboxrd@z Thu Jan 1 00:00:00 1970 From: Govindarajulu Varadarajan Subject: Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare Date: Mon, 30 Dec 2013 13:42:18 +0530 (IST) Message-ID: References: <52C12378.7030801@huawei.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Christian Benvenuti , Sujith Sankar , Govindarajulu Varadarajan , Neel Patel , Nishank Trivedi , "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" To: Ding Tianhong Return-path: Received: from bgl-iport-3.cisco.com ([72.163.197.27]:27732 "EHLO bgl-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467Ab3L3IVu (ORCPT ); Mon, 30 Dec 2013 03:21:50 -0500 In-Reply-To: <52C12378.7030801@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 30 Dec 2013, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal > to instead of memcmp. > > Cc: Christian Benvenuti > Cc: Sujith Sankar > Cc: Govindarajulu Varadarajan > Cc: Neel Patel > Cc: Nishank Trivedi > Signed-off-by: Ding Tianhong > --- > drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c b/drivers/net/ethernet/cisco/enic/enic_pp.c > index 43464f0..e6a8319 100644 > --- a/drivers/net/ethernet/cisco/enic/enic_pp.c > +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c > @@ -162,7 +162,7 @@ static int enic_are_pp_different(struct enic_port_profile *pp1, > return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid, > pp2->instance_uuid, PORT_UUID_MAX) | > !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) | > - !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN); > + !ether_addr_equal(pp1->mac_addr, pp2->mac_addr); > } > > static int enic_pp_preassociate(struct enic *enic, int vf, > -- > 1.8.0 > looks good for me Acked-by: Govindarajulu Varadarajan