Re: [PATCH] jme: Fix DMA unmap warning

[Govindarajulu Varadarajan <_govind@gmx.com>]

On Tue, 6 May 2014, David Miller wrote:

> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Tue, 6 May 2014 16:50:46 -0400
>
>>>> +		ctxbi = txbi + ((startidx + j + 2) & (mask));
>>>> +		pci_unmap_page(jme->pdev,
>>>> +				ctxbi->mapping,
>>>> +				ctxbi->len,
>>>> +				PCI_DMA_TODEVICE);
>>>> +
>>>> +				ctxbi->mapping = 0;
>>>> +				ctxbi->len = 0;
>>>
>>> Alignment, a tab from 'for'
>> Not sure what you mean by this, I don't see any alignment errors above, or in my
>> tree.  Checkpatch also claims its clean.
>
> Indeed it is indented correctly, the "+" at the beginning of the line in
> the patch makes it look like it's not, but it is.
>

Hmm. This is how it looked when I applied the patch.
http://i.imgur.com/ZdjqJ3d.png

ctxbi->mapping = 0;
ctxbi->len = 0;

is aligned to '(' of pci_unmap_page. But these two statements are not arg of
the function. Shouldn't it be aligned along pci_unmap_page and not '('

Govind