Re: [PATCH net-next] enic: Add support for adaptive interrupt coalescing

[Govindarajulu Varadarajan <gvaradar@cisco.com>]

On Wed, 7 May 2014, David Miller wrote:

> From: Govindarajulu Varadarajan <_govind@gmx.com>
> Date: Tue,  6 May 2014 19:54:22 +0530
>
>> From: Sujith Sankar <ssujith@cisco.com>
>>
>> Signed-off-by: Sujith Sankar <ssujith@cisco.com>
>> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
>
> Please never submit patches except absolutely the most extremely
> trivial ones without a real commit log message explaining what
> the change does, how it does it, and why you implemented it that
> way.
>

Will add more description. Sorry

>> +enum hrtimer_restart enic_hrtimer_cb(struct hrtimer *timer)
>> +{
>> +	return HRTIMER_RESTART;
>> +}
>
> For example, I have no idea why in the world you need an hrtimer whose
> function is a complete NOP if the networking hardware does the
> interrupt coalescing for you.
>

The idea was to get time delta in usec, to measure the pkt rate. We want to 
make damping of coal timer more aggressive. I guess we can use ktime_get() 
instead of hrtimers.

Will resubmit the patch with changes in a week. Let us know if anything else 
needs to be changed.

thanks
Govind