From: Govindarajulu Varadarajan <_govind@gmx.com>
To: David Miller <davem@davemloft.net>
Cc: _govind@gmx.com, netdev@vger.kernel.org, ssujith@cisco.com,
benve@cisco.com
Subject: Re: [PATCH net-next] enic: Add ethtool support to show classifier filters added by the driver
Date: Sat, 12 Jul 2014 14:09:15 +0530 (IST) [thread overview]
Message-ID: <alpine.LNX.2.03.1407121406100.1782@ws.cisco> (raw)
In-Reply-To: <20140711.145917.653569199285104303.davem@davemloft.net>
On Fri, 11 Jul 2014, David Miller wrote:
> From: Govindarajulu Varadarajan <_govind@gmx.com>
> Date: Fri, 11 Jul 2014 14:44:11 +0530
>
>> Right now Accelerated RFS is the only feature which adds classifier filters.
>> So enable get_rxnfc only when CONFIG_RFS_ACCEL = y
> ...
>> @@ -293,6 +389,9 @@ static const struct ethtool_ops enic_ethtool_ops = {
>> .get_ethtool_stats = enic_get_ethtool_stats,
>> .get_coalesce = enic_get_coalesce,
>> .set_coalesce = enic_set_coalesce,
>> +#ifdef CONFIG_RFS_ACCEL
>> + .get_rxnfc = enic_get_rxnfc,
>> +#endif
>
> No other driver protects this method in this way, please don't do this.
>
I will move the ifdef's to .h files and resubmit.
Thanks
next prev parent reply other threads:[~2014-07-12 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 9:14 [PATCH net-next] enic: Add ethtool support to show classifier filters added by the driver Govindarajulu Varadarajan
2014-07-11 21:59 ` David Miller
2014-07-12 8:39 ` Govindarajulu Varadarajan [this message]
2014-07-13 7:31 ` David Miller
2014-07-14 6:58 ` Govindarajulu Varadarajan
2014-07-14 7:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.03.1407121406100.1782@ws.cisco \
--to=_govind@gmx.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).