netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Enrico Mioso <mrkiko.rs@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net,stable] net: huawei_cdc_ncm: add "subclass 3" devices
Date: Fri, 18 Jul 2014 17:14:39 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.03.1407181713530.687@gmail.com> (raw)
In-Reply-To: <1405596849-11800-1-git-send-email-bjorn@mork.no>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2480 bytes --]

Seems interesting
That's fine.

Acked-By: Enrico Mioso <mrkiko.rs@gmail.com>

On Thu, 17 Jul 2014, Bjørn Mork wrote:

==Date: Thu, 17 Jul 2014 13:34:09
==From: Bjørn Mork <bjorn@mork.no>
==To: netdev@vger.kernel.org
==Cc: linux-usb@vger.kernel.org, Bjørn Mork <bjorn@mork.no>,
==    Enrico Mioso <mrkiko.rs@gmail.com>
==Subject: [PATCH net,stable] net: huawei_cdc_ncm: add "subclass 3" devices
==
==Huawei's usage of the subclass and protocol fields is not 100%
==clear to us, but there appears to be a very strict system.
==
==A device with the "shared" device ID 12d1:1506 and this NCM
==function was recently reported (showing only default altsetting):
==
==    Interface Descriptor:
==      bLength                 9
==      bDescriptorType         4
==      bInterfaceNumber        1
==      bAlternateSetting       0
==      bNumEndpoints           1
==      bInterfaceClass       255 Vendor Specific Class
==      bInterfaceSubClass      3
==      bInterfaceProtocol     22
==      iInterface              8 CDC Network Control Model (NCM)
==      ** UNRECOGNIZED:  05 24 00 10 01
==      ** UNRECOGNIZED:  06 24 1a 00 01 1f
==      ** UNRECOGNIZED:  0c 24 1b 00 01 00 04 10 14 dc 05 20
==      ** UNRECOGNIZED:  0d 24 0f 0a 0f 00 00 00 ea 05 03 00 01
==      ** UNRECOGNIZED:  05 24 06 01 01
==      Endpoint Descriptor:
==        bLength                 7
==        bDescriptorType         5
==        bEndpointAddress     0x85  EP 5 IN
==        bmAttributes            3
==          Transfer Type            Interrupt
==          Synch Type               None
==          Usage Type               Data
==        wMaxPacketSize     0x0010  1x 16 bytes
==        bInterval               9
==
==Cc: Enrico Mioso <mrkiko.rs@gmail.com>
==Signed-off-by: Bjørn Mork <bjorn@mork.no>
==---
== drivers/net/usb/huawei_cdc_ncm.c | 3 +++
== 1 file changed, 3 insertions(+)
==
==diff --git a/drivers/net/usb/huawei_cdc_ncm.c b/drivers/net/usb/huawei_cdc_ncm.c
==index 5d95a13dbe2a..735f7dadb9a0 100644
==--- a/drivers/net/usb/huawei_cdc_ncm.c
==+++ b/drivers/net/usb/huawei_cdc_ncm.c
==@@ -194,6 +194,9 @@ static const struct usb_device_id huawei_cdc_ncm_devs[] = {
== 	{ USB_VENDOR_AND_INTERFACE_INFO(0x12d1, 0xff, 0x02, 0x76),
== 	  .driver_info = (unsigned long)&huawei_cdc_ncm_info,
== 	},
==+	{ USB_VENDOR_AND_INTERFACE_INFO(0x12d1, 0xff, 0x03, 0x16),
==+	  .driver_info = (unsigned long)&huawei_cdc_ncm_info,
==+	},
== 
== 	/* Terminating entry */
== 	{
==-- 
==2.0.1
==
==

      parent reply	other threads:[~2014-07-18 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17 11:34 [PATCH net,stable] net: huawei_cdc_ncm: add "subclass 3" devices Bjørn Mork
2014-07-17 23:51 ` David Miller
2014-07-18 15:14 ` Enrico Mioso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.03.1407181713530.687@gmail.com \
    --to=mrkiko.rs@gmail.com \
    --cc=bjorn@mork.no \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).