Re: [PATCH net-next 2/3] ethtool: add rx_copybreak support

[Govindarajulu Varadarajan <_govind@gmx.com>]

On Tue, 22 Jul 2014, Ben Hutchings wrote:

> On Tue, 2014-07-22 at 23:01 +0530, Govindarajulu Varadarajan wrote:
>> This patch adds rx_copybreak support to ethtool.h header file.
>> This is used to show/set rx_copybreak using ethtool.
>>
>> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
>> ---
>>  include/uapi/linux/ethtool.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
>> index e3c7a71..d2912ad 100644
>> --- a/include/uapi/linux/ethtool.h
>> +++ b/include/uapi/linux/ethtool.h
>> @@ -433,10 +433,12 @@ struct ethtool_ringparam {
>>  	__u32	rx_mini_max_pending;
>>  	__u32	rx_jumbo_max_pending;
>>  	__u32	tx_max_pending;
>> +	__u32	rx_max_copybreak_pending;
>>  	__u32	rx_pending;
>>  	__u32	rx_mini_pending;
>>  	__u32	rx_jumbo_pending;
>>  	__u32	tx_pending;
>> +	__u32	rx_copybreak_pending;
>>  };
>>
>>  /**
>
> No, you can't rearrange UAPI structures like this.
>

So I will move these 2 variables to the end of the struct?
Also in ethtool-copy.h in ethtool.

Thanks