From: Govindarajulu Varadarajan <_govind@gmx.com>
To: David Miller <davem@davemloft.net>
Cc: _govind@gmx.com, ben@decadent.org.uk, netdev@vger.kernel.org,
ssujith@cisco.com, benve@cisco.com
Subject: Re: [PATCH net-next v2 2/3] ethtool: Add support for DMA buffer settings
Date: Fri, 1 Aug 2014 03:33:26 +0530 (IST) [thread overview]
Message-ID: <alpine.LNX.2.03.1408010331120.458@ws.cisco> (raw)
In-Reply-To: <20140730.175306.483788306179792581.davem@davemloft.net>
On Wed, 30 Jul 2014, David Miller wrote:
> However I wonder what value that "max" thing has, I think setting the
> value to infinity is just fine, it just means every packet will be
> copied.
>
> So if we remove the 'max', we just have the copybreak itself, and you
> can therefore use ethtool_value and allocate the ethtool command
> numbers.
Yes, we can drop the max thing.
I will use ethtool_value and allocate new ethtool command for rx_copybreak
and send the patch soon.
Thanks
next prev parent reply other threads:[~2014-07-31 22:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 11:40 [PATCH net-next v2 0/3] enic: Add support for rx_copybreak Govindarajulu Varadarajan
2014-07-29 11:40 ` [PATCH net-next v2 1/3] enic: implement rx_copybreak Govindarajulu Varadarajan
2014-07-29 11:40 ` [PATCH net-next v2 2/3] ethtool: Add support for DMA buffer settings Govindarajulu Varadarajan
2014-07-31 0:53 ` David Miller
2014-07-31 22:03 ` Govindarajulu Varadarajan [this message]
2014-08-02 13:56 ` Ben Hutchings
2014-08-02 14:26 ` Stephen Hemminger
2014-08-02 15:06 ` Ben Hutchings
2014-08-07 21:56 ` Govindarajulu Varadarajan
2014-08-04 22:15 ` David Miller
2014-07-29 11:40 ` [PATCH net-next v2 3/3] enic: add ethtool support set/show rx_copybreak Govindarajulu Varadarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.03.1408010331120.458@ws.cisco \
--to=_govind@gmx.com \
--cc=ben@decadent.org.uk \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).