From: Enrico Mioso <mrkiko.rs@gmail.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame
Date: Tue, 7 Jul 2015 22:50:41 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.20.1507072243460.9655@localhost.localdomain> (raw)
In-Reply-To: <1436177296.8225.25.camel@suse.com>
Hi Oliver, hello to who is reading this message.
i was re-reading the code and the oops, without understanding what's the
problem. Still: what impressed me is the fact that at some point you see NULL
ptr dereference in unrelated code (fbcon). Is it possible that at some point
the memory portion (172 bytes if device is affected by NCM errata, and mine
is), that the portion of memory to which ctx->delayed_ndp16 points to is
somehow moved / thrown away?
It doesn't make sense, because otherwise even accesses to the ctx variable
would give problems. And they don't.
Looking around then, I see kzalloc() / kmalloc (kzalloc =kmalloc | __GFP_ZERO)
are used to allocate any size of memory (with the only requirement for it to be
small). In rndis_host.c 1025 bytes (not 1024) are allocated, so I am excluding
any kind of alignment problem here.
Thank you,
Enrico
next prev parent reply other threads:[~2015-07-07 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 21:55 [PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame Enrico Mioso
[not found] ` <1435787748-30393-1-git-send-email-mrkiko.rs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-07-05 10:21 ` Enrico Mioso
2015-07-06 10:08 ` Oliver Neukum
[not found] ` <1436177296.8225.25.camel-IBi9RG/b67k@public.gmane.org>
2015-07-06 11:53 ` Enrico Mioso
2015-07-06 11:56 ` Enrico Mioso
2015-07-07 20:50 ` Enrico Mioso [this message]
2015-07-08 7:54 ` Enrico Mioso
2015-07-08 11:15 ` Enrico Mioso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.1507072243460.9655@localhost.localdomain \
--to=mrkiko.rs@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox