From: Govindarajulu Varadarajan <gvaradar@cisco.com>
To: PJ Waskiewicz <pjwaskiewicz@gmail.com>
Cc: <netdev@vger.kernel.org>, Christian Benvenuti <benve@cisco.com>,
Govindarajulu Varadarajan <_govind@gmx.com>,
Neel Patel <neepatel@cisco.com>
Subject: Re: [PATCH] enic: Store permanent MAC address during probe()
Date: Mon, 20 Mar 2017 18:49:21 -0700 [thread overview]
Message-ID: <alpine.LNX.2.20.1703201835570.17033@cisco> (raw)
In-Reply-To: <CACMb8d1o=YGsA0VoNQAA6_svLFz3X7EnD4g_AXXvBg2oO_1hjQ@mail.gmail.com>
On Mon, 20 Mar 2017, PJ Waskiewicz wrote:
> On Mon, Mar 20, 2017 at 5:33 PM, Govindarajulu Varadarajan
> <gvaradar@cisco.com> wrote:
>> On Mon, 20 Mar 2017, PJ Waskiewicz wrote:
>>
>>> From: PJ Waskiewicz <pjwaskiewicz@gmail.com>
>>>
>>> The permanent MAC address is useful to store for things like ethtool,
>>> and when bonding with modes such as active/passive or LACP.
>>
>> Is this patch fixing an issue with bonding drive on enic?
>
> We noticed that running ethtool -P <eth> on an enic, even on 4.9,
> returned nothing. This has fallout when using bonding, where LACP or
> Active/Passive overrides the LAA on one of the slaves, one can't
> figure out what the physical MAC address is of each slave. So not a
> problem with bonding directly, it's more secondary as a result of the
> driver not reporting the actual permanent address.
>
>>
>>> This follows the model of other Ethernet drivers, such as ixgbe.
>>>
>>
>> While other drivers set netdev->perm_addr, doesn't this actually come free
>> in
>> register_netdevice().
>
> I thought it did as well, but in 4.9 when we tested it wasn't working.
> Hence the patch. :-)
>
Can you try with net-next? In my setup I do not see the issue on net-next and on
4.9 kernel. The issue for all drivers was fixed in
948b337e62ca9 ("net: init perm_addr in register_netdevice()")
next prev parent reply other threads:[~2017-03-21 1:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 22:41 [PATCH] enic: Store permanent MAC address during probe() PJ Waskiewicz
2017-03-21 0:33 ` Govindarajulu Varadarajan
2017-03-21 0:37 ` PJ Waskiewicz
2017-03-21 1:49 ` Govindarajulu Varadarajan [this message]
2017-03-21 6:20 ` PJ Waskiewicz
2017-03-22 18:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.1703201835570.17033@cisco \
--to=gvaradar@cisco.com \
--cc=_govind@gmx.com \
--cc=benve@cisco.com \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pjwaskiewicz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).